Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added $event to on-day-click second param after date #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emps
Copy link

@emps emps commented Dec 21, 2015

$event added as second parameter just to not make problems with ppl that use first param for date,
this helps with md-dialog while u need to add an click $event from where and to where open/close the dialog with $mdDialog targetEvent: $event,

@bradberger
Copy link
Collaborator

Awesome, thanks for the contribution. Going to check it out in the next couple of days when I have a chance, but it looks good and hope to merge it ASAP.

@gavinbarron
Copy link
Collaborator

This needs some fixes to resolve merge conflicts.

@jaspersorrio
Copy link

This is a much need feature. It's already Oct 2016.. Can we look into this again?

@maroun-baydoun
Copy link

@bradberger Are there any plans to merge this and release it?

@bradberger
Copy link
Collaborator

bradberger commented Sep 14, 2017 via email

@maroun-baydoun
Copy link

@bradberger Thank you for your reply.
I would be happy to help in any capacity I can.

Copy link
Collaborator

@bradberger bradberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The handleDayClick should be backwards compatible, so $event should be the second parameter. Other than that I think that we should move ahead with the merge.

};

$scope.handleDayClick = function (date) {
$scope.handleDayClick = function ($event, date) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks backwards compatibility, so it should be $scope.handleDayClick = function(date, $event) so as to be backwards compatible

@bradberger
Copy link
Collaborator

bradberger commented Sep 14, 2017

Is anyone available to fix the merge issues and update the order of the handleDayClick parameters so we can merge this? cc/ @maroun-baydoun @emps @jaspersorrio

@maroun-baydoun
Copy link

@bradberger Opened #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants