-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added $event to on-day-click second param after date #40
base: master
Are you sure you want to change the base?
Conversation
Awesome, thanks for the contribution. Going to check it out in the next couple of days when I have a chance, but it looks good and hope to merge it ASAP. |
This needs some fixes to resolve merge conflicts. |
This is a much need feature. It's already Oct 2016.. Can we look into this again? |
@bradberger Are there any plans to merge this and release it? |
I missed it, sorry about that. Let me take a look and try to get it merged
today. Feel free to keeping bugging me if I don't get to it immediately.
I think it's also safe to say we could use more maintainers. I just don't
have time right now. Would you be interested?
|
@bradberger Thank you for your reply. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The handleDayClick
should be backwards compatible, so $event should be the second parameter. Other than that I think that we should move ahead with the merge.
}; | ||
|
||
$scope.handleDayClick = function (date) { | ||
$scope.handleDayClick = function ($event, date) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks backwards compatibility, so it should be $scope.handleDayClick = function(date, $event)
so as to be backwards compatible
Is anyone available to fix the merge issues and update the order of the |
@bradberger Opened #120 |
$event added as second parameter just to not make problems with ppl that use first param for date,
this helps with md-dialog while u need to add an click $event from where and to where open/close the dialog with $mdDialog targetEvent: $event,