Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try adding the JSpecify annotations to see if it helps with CI. #100

Closed
wants to merge 3 commits into from

Conversation

cpovirk
Copy link
Collaborator

@cpovirk cpovirk commented Oct 7, 2024

#99

@cpovirk
Copy link
Collaborator Author

cpovirk commented Oct 7, 2024

Well, not only does the build still fail, but I don't seem to have succeeded even at limiting the number of platforms that it runs for... :) (I had changed only "defaults," so I probably need to look into the values that are actually passed by the events themselves—or into changing where the set of events is defined?)

I wonder if what we're seeing is that the initial builds are bootstrapping the JDK by building it with a preexisting JDK. If so, we'd likely need to use --patch-module to add the JSpecify annotations to the existing JDK system APIs. At that point, we might consider using --patch-module throughout instead of actually compiling the annotations into the JDK.

@cpovirk cpovirk closed this Oct 7, 2024
@cpovirk cpovirk mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant