Merge pull request #28 from jsr-core/fix-mutex

fix: properly clear internal waiters on `Mutex`
jsr-core · Aug 12, 2024 · b000238 · b000238
2 parents e8a2fce + e324508
commit b000238
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 3 deletions.
diff --git a/deno.lock b/deno.lock
diff --git a/mutex.ts b/mutex.ts
@@ -26,13 +26,13 @@
  * ```
  */
 export class Mutex {
-  #waiters: Promise<void>[] = [];
+  #waiters: Set<Promise<void>> = new Set();
 
   /**
    * Returns true if the mutex is locked, false otherwise.
    */
   get locked(): boolean {
-    return this.#waiters.length > 0;
+    return this.#waiters.size > 0;
   }
 
   /**
@@ -43,10 +43,11 @@ export class Mutex {
   acquire(): Promise<Disposable> & Disposable {
     const waiters = [...this.#waiters];
     const { promise, resolve } = Promise.withResolvers<void>();
-    this.#waiters.push(promise);
+    this.#waiters.add(promise);
     const disposable = {
       [Symbol.dispose]: () => {
         resolve();
+        this.#waiters.delete(promise);
       },
     };
     return Object.assign(