Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Extractor doesn't parse the HTML files for Angular v19 #208

Closed
1 task done
medbenmakhlouf opened this issue Dec 3, 2024 · 3 comments
Closed
1 task done

Bug: Extractor doesn't parse the HTML files for Angular v19 #208

medbenmakhlouf opened this issue Dec 3, 2024 · 3 comments

Comments

@medbenmakhlouf
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Is this a regression?

Yes

Current behavior

when I run "npm run i18n:extract" as "transloco-keys-manager extract" it doesn't read my keys in HTML files. I have attached the link to reproduce the error.
Screenshot 2024-12-03 at 12 09 50

Expected behavior

it should extract the keys in json files

Please provide a link to a minimal reproduction of the bug

https://stackblitz.com/edit/stackblitz-starters-5dhmqs?file=src%2Fapp%2Fapp.component.ts

Transloco Config

No response

Debug Logs

No response

Please provide the environment you discovered this bug in

Transloco: 7.5.0
Transloco Keys Manager: 6.0.0
Angular: 19.0.0
Node: 22.11.0
Package Manager: npm
OS: MAcOs

Additional context

No response

I would like to make a pull request for this bug

No
@medbenmakhlouf
Copy link
Contributor Author

@shaharkazaz I found out to just update the package.json with v19 for Angular. Here is a PR that fix the issue! Thanks

medbenmakhlouf pushed a commit to medbenmakhlouf/transloco-keys-manager that referenced this issue Dec 3, 2024
feat: 🎸 support angular v19
a37f451 
BREAKING CHANGE: 🧨 drop support for angular < 19

✅ Closes: jsverse#208
@medbenmakhlouf medbenmakhlouf mentioned this issue Dec 3, 2024
Closed
3 tasks
@HitomiTenshi
Copy link

While #210 is not released, you can workaround this issue by adding the following to your package.json:

"overrides": {
  "@jsverse/transloco-keys-manager": {
    "@angular/compiler": "^19.0.0"
  }
}

@shaharkazaz
Copy link
Collaborator

Released in v6.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 🎸 support angular v19 medbenmakhlouf/transloco-keys-manager
3 participants
@HitomiTenshi @medbenmakhlouf @shaharkazaz