Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 support angular v19 #210

Closed
wants to merge 1 commit into from

Conversation

medbenmakhlouf
Copy link
Contributor

@medbenmakhlouf medbenmakhlouf commented Dec 3, 2024

BREAKING CHANGE: 🧨 drop support for angular < 19

βœ… Closes: #208

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[X] Yes
[ ] No

Other information

BREAKING CHANGE: 🧨 drop support for angular < 19

βœ… Closes: jsverse#208
@newaeonweb
Copy link

newaeonweb commented Dec 9, 2024

maybe this solution is not enough, I notice that some translations are broken. I mean, the translations that already existed are lost.

@shaharkazaz
Copy link
Collaborator

Duplicate of #209

@shaharkazaz shaharkazaz marked this as a duplicate of #209 Dec 19, 2024
@medbenmakhlouf medbenmakhlouf deleted the support-ng-19 branch December 19, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Extractor doesn't parse the HTML files for Angular v19
3 participants