Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Support Angular v19 #209

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

medbenmakhlouf
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ X] No

Other information

@shaharkazaz
Copy link
Collaborator

@medbenmakhlouf Thanks! did you use the commit command?

@medbenmakhlouf
Copy link
Contributor Author

@shaharkazaz , I think I didn't , should I revert my changes and do another one with npm run commit ?

@shaharkazaz
Copy link
Collaborator

@medbenmakhlouf Yes please 🙂 Can you please mark this as a breaking change as well? it's part of the steps when committing, just write there "support Angular v19"

@medbenmakhlouf
Copy link
Contributor Author

@shaharkazaz , I tried to change message commit here, or better I created a new PR here with respecting the npm run commit. if you are happy with new one, I will close this one.

@medbenmakhlouf
Copy link
Contributor Author

@shaharkazaz, Do you have an idea of when you plan to release this? Thanks!

@shaharkazaz
Copy link
Collaborator

@medbenmakhlouf I'll do it as soon as I have some time, I think this week 🙂

@shaharkazaz shaharkazaz merged commit f11ffff into jsverse:master Dec 19, 2024
2 checks passed
@shaharkazaz shaharkazaz mentioned this pull request Dec 19, 2024
3 tasks
@medbenmakhlouf medbenmakhlouf deleted the support-angular-v19 branch December 19, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants