fix: resolveProjectBasePath could not find source root when directory… #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… name and project name are different prior to this change we would look for `**/<projectName>` however this does not work when we have a folder structure like: `/libs/ui/my-button` where the project name would be `ui-my-button` causing the keys not to be detected this change would look for all project.json files and look for the correct project.json by comparing the name property within
|
|
|
Hi, any reason why this hasn't been merged? I was wondering why some keys on my project weren't being extracted. Turns out, a lot weren't because of this. Applied it locally and works fine... |
|
I'll try to review this week 👍 |
shaharkazaz
reviewed
Aug 12, 2023
Comment on lines
+47
to
61
| let projectConfig; | ||
| if (projectName) { | ||
| projectPath = normalizedGlob(`**/${projectName}`)[0]; | ||
| // look for all project.json files and find the project.json that contains | ||
| // { name: "<projectName>" ... } | ||
| const projectConfigs = normalizedGlob(`**/${projectConfigFile}`); | ||
| for(const p of projectConfigs) { | ||
| const config = searchConfig(projectConfigFile, p); | ||
| if(config.name === projectName) { | ||
| projectConfig = config; | ||
| break; | ||
| } | ||
| } | ||
| } else { | ||
| projectConfig = searchConfig(projectConfigFile, projectPath); | ||
| } |
There was a problem hiding this comment.
Let's move this into resolveProjectConfig and merge 👍
shaharkazaz
reviewed
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… name and project name are different
prior to this change we would look for
**/<projectName>however this does not work when we have a folder structure like:/libs/ui/my-buttonwhere the project name would beui-my-buttoncausing the keys not to be detected this change would look for all project.json files and look for the correct project.json by comparing the name property withinPR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently when having a folder structure where the project name does not match the folder name transloco-key-manager is unable to find the source root.
for example if we would have
libs/booking/ui/button when looking for a project with the name
booking-ui-buttontransloco won't find the source root of this project causing the error:Issue Number: N/A
What is the new behavior?
with the changes in this PR we look for all
project.jsonand compare thenameproperty to find out if it is the correct config file.this enables us to have folder structures like
/booking/ui/button
/booking/ui/card
/invoicing/ui/button
And before when running
npx transloco-keys-manager extract --project=buttonit would match one of these libraries but never the other. This change would also make this possible where everything is correctly matched based on the project name that is specified in project.json ( project name should still be unique in each workspace elsenxwill not work correctly either ).Does this PR introduce a breaking change?