Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add scope support for marker function #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kekel87
Copy link
Contributor

@kekel87 kekel87 commented Mar 25, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The marker function does not support scopes.
Some users use this workaround to get them, but it is induced by an unintentional implementation when extracting parameters.

Issue Number: #178, #132

What is the new behavior?

We can now indicate an optional scope in the marker function (or an alias).
marker is resolved independently of translate or selectTranslate.
Its typing has been updated accordingly.

Does this PR introduce a breaking change?

[X] Yes
[ ] No

Users using this workaround should delete it and update their marker function with scope.

Other information

@shaharkazaz following this discussion

@shaharkazaz
Copy link
Collaborator

@kekel87 Sorry it took me a while to get back
Would you like to reboot this?

@kekel87
Copy link
Contributor Author

kekel87 commented Aug 26, 2024

Hi, there,
Sorry a lot of work this summer and a new ongoing personal project 👶 😅 .
I'll see if I can find the time to rebase and resume this.
No guarantees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants