feat: 🎸 add scope support for marker function #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
marker
function does not support scopes.Some users use this workaround to get them, but it is induced by an unintentional implementation when extracting parameters.
Issue Number: #178, #132
What is the new behavior?
We can now indicate an optional scope in the marker function (or an alias).
marker
is resolved independently oftranslate
orselectTranslate
.Its typing has been updated accordingly.
Does this PR introduce a breaking change?
Users using this workaround should delete it and update their marker function with scope.
Other information
@shaharkazaz following this discussion