Skip to content

Commit

Permalink
fix: fix version pass from bump-tag job to create-github-release-with…
Browse files Browse the repository at this point in the history
…-changelog
  • Loading branch information
jtbonhomme committed Jan 16, 2023
1 parent 3207404 commit 2d43181
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 15 deletions.
15 changes: 1 addition & 14 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,20 +28,7 @@ jobs:
echo ${{ steps.semantic_release.outputs.new_release_major_version }}
echo ${{ steps.semantic_release.outputs.new_release_minor_version }}
echo ${{ steps.semantic_release.outputs.new_release_patch_version }}
echo "${{ steps.semantic_release.outputs.new_release_version }}" >> $GITHUB_OUTPUT
#- name: Bump version and push tag
# id: create_version_push_tag
# uses: anothrNick/[email protected] # Don't use @master unless you're happy to test the latest version
# env:
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# WITH_V: true
# VERBOSE: true

#- run: |
# echo "created anothrNick new_tag ${{ steps.create_version_push_tag.outputs.new_tag }}"
# echo "created anothrNick tag ${{ steps.create_version_push_tag.outputs.tag }}"
# echo "created anothrNick part ${{ steps.create_version_push_tag.outputs.part }}"
echo "tag=${{ steps.semantic_release.outputs.new_release_version }}" >> $GITHUB_OUTPUT
#- name: "Create latest tag"
# id: create_latest_tag
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Dummy demonstration http server.
### To Do

* [X] Automatic tag + GH release
* [ ] Fix auto tag (no actual analyse of PRs)
* [X] Fix auto tag (no actual analyse of PRs)
* [ ] Fix changelog (fix are uncategorized)
* [X] Create and commit SVG badge in pushed branch
* [ ] Pass tests coverage as artifact between test and badge

0 comments on commit 2d43181

Please sign in to comment.