Added check for DHEater vulnerability and updated relevant tests (#211) #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check for the DHEater vulnerability mentioned here: #211
And updated the tests. two things to note:
Considering this issue is in the algorithm not the server, the vulnerability was documented in the algorithm itself rather than the CVEs section.
And I did have to edit the following docker test to expect a failure instead of a success:
749: run_openssh_test "8.0p1" "test3" "${PROGRAM_RETVAL_FAILURE}"
I'm not sure if it's fine this way or if would you want to update the docker OpenSSH config instead.
Either way, I thought I'd mention these here to be sure.