-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a --kube-version
option to pass to helm template
#24
Add a --kube-version
option to pass to helm template
#24
Conversation
Currently, templates are only generated with the current Kubernetes version, but it is possible to validate against any schema. This means that it's not actually possible to generate what you intend to validate. This commit adds `--kube-version` option, which gets passed down to `helm template`. This option is deliberately separate from `--kubernetes-version` because a) they are passed to two different commands and b) there may be reasons why a user might want to validate against a schema that doesn't match what the template was generated for, such as to validate cross-version compatibility.
Thanks for creating this PR, @deriamis. Please could you make the default value of |
Sure, no problem. One moment and I'll push that change - once my keyboard stops being silly. |
@jtyr I've made the change as requested. FYI, I have tested the change already in a Docker env as well:
|
It looks good. Please bump the version and we can merge it. |
@jtyr Done! |
Thanks for your contribution, @deriamis. |
Currently, templates are only generated with the current Kubernetes version, but it is possible to validate against any schema. This means that it's not actually possible to generate what you intend to validate. This commit adds
--kube-version
option, which gets passed down tohelm template
. The option default is whatever--kubernetes-version
is set to, if set.This option is deliberately separate from
--kubernetes-version
because a) they are passed to two different commands and b) there may be reasons why a user might want to validate against a schema that doesn't match what the template was generated for, such as to validate cross-version compatibility.