Fix build failures without SIMD #1277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new mention of SIMDRegister here should be guarded on JUCE_USE_SIMD too, to fix the following build failures present on riscv64 and other platforms:
```
In file included from /build/juce/src/JUCE-7.0.7/modules/juce_dsp/juce_dsp.cpp:103:
/build/juce/src/JUCE-7.0.7/modules/juce_dsp/containers/juce_AudioBlock_test.cpp:32:34: error: ‘SIMDRegister’ has not been declared
32 | String& operator<< (String& str, SIMDRegister<SampleType>) { return str; }
| ^~~~~~~~~~~~
/build/juce/src/JUCE-7.0.7/modules/juce_dsp/containers/juce_AudioBlock_test.cpp:32:46: error: expected ‘,’ or ‘...’ before ‘<’ token
32 | String& operator<< (String& str, SIMDRegister<SampleType>) { return str; }
| ^
```
felixonmars
added a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Sep 23, 2023
Patch submitted at juce-framework/JUCE#1277
felixonmars
added a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Sep 23, 2023
Patch submitted at juce-framework/JUCE#1277
Thanks for reporting @felixonmars, I'll take a look at this now. |
|
Thanks for raising. This should now be fixed in this commit. |
aimixsaka
added a commit
to aimixsaka/archriscv-packages
that referenced
this pull request
Oct 26, 2023
- patch in "github.com/juce-framework/JUCE/pull/1277" merged in commit "juce-framework/JUCE@f893a12" - Successfully build without patch
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Oct 27, 2023
- patch in "github.com/juce-framework/JUCE/pull/1277" merged in commit "juce-framework/JUCE@f893a12" - Successfully build without patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new mention of SIMDRegister here should be guarded on JUCE_USE_SIMD too, to fix the following build failures present on riscv64 and other platforms: