-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI parameter parsing to bootstrap script #228
Add CLI parameter parsing to bootstrap script #228
Conversation
Honestly, I did not update the README yet, as I wanted to make sure, the PR is valid and that the CLI can be agreed upon. |
ee1ca1e
to
13c156e
Compare
|
||
You should be prepared to have a live internet connection when browsing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a command to catch up the full history manually afterwards? Then we could also list that here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have found this link. Should I add it in some way (a script?) or just document what would be needed to be done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A script would of course be nice, but I'd also be fine just documenting it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have a look into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a small script to unshallow/unpartial any existing repository. This script can be used rather generically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question, otherwise very cool addition 🙏
db103f0
to
f76760a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave this some try and works nicely. @christianlupus Could you rebase this to latest master branch? I tried but could not push to your fork.
Uups, sorry. Obviously, I missed to set you be able to write to the branch. I will rebase and incorporate soon. |
f76760a
to
e3f3e5b
Compare
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
e3f3e5b
to
853e7f9
Compare
OK, I rebased onto master. I think there are no side-effects with other parts of the script. I was unsure about the ordering of the test on the |
Ordering seems good as we only clone with bootstrap on the initial setup call once I'd say. |
Thanks a lot for that. |
Might be worth to extend the docs around that a bit as well. |
Closes #130
This is just a first approach at making the bootstrap bash function CLI parameter-aware.
Feel free to comment, fix, or reject.