Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI parameter parsing to bootstrap script #228

Conversation

christianlupus
Copy link
Contributor

@christianlupus christianlupus commented Sep 18, 2023

Closes #130

This is just a first approach at making the bootstrap bash function CLI parameter-aware.

Feel free to comment, fix, or reject.

@christianlupus
Copy link
Contributor Author

Honestly, I did not update the README yet, as I wanted to make sure, the PR is valid and that the CLI can be agreed upon.

@christianlupus christianlupus force-pushed the enhance/bootstrp-with-params branch from ee1ca1e to 13c156e Compare September 18, 2023 14:03

You should be prepared to have a live internet connection when browsing the
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a command to catch up the full history manually afterwards? Then we could also list that here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found this link. Should I add it in some way (a script?) or just document what would be needed to be done?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A script would of course be nice, but I'd also be fine just documenting it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have a look into this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a small script to unshallow/unpartial any existing repository. This script can be used rather generically.

Copy link
Owner

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question, otherwise very cool addition 🙏

@christianlupus christianlupus force-pushed the enhance/bootstrp-with-params branch 2 times, most recently from db103f0 to f76760a Compare October 17, 2023 15:39
Copy link
Owner

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this some try and works nicely. @christianlupus Could you rebase this to latest master branch? I tried but could not push to your fork.

@christianlupus
Copy link
Contributor Author

Uups, sorry. Obviously, I missed to set you be able to write to the branch. I will rebase and incorporate soon.

@christianlupus christianlupus force-pushed the enhance/bootstrp-with-params branch from f76760a to e3f3e5b Compare December 5, 2023 09:07
@christianlupus christianlupus force-pushed the enhance/bootstrp-with-params branch from e3f3e5b to 853e7f9 Compare December 5, 2023 09:11
@christianlupus
Copy link
Contributor Author

OK, I rebased onto master. I think there are no side-effects with other parts of the script. I was unsure about the ordering of the test on the .env file and the CLI parameters. I did not merge, yet, as I wanted to give you a chance to once more look at things. Feel free to merge or comment.

@juliusknorr
Copy link
Owner

Ordering seems good as we only clone with bootstrap on the initial setup call once I'd say.

@juliusknorr juliusknorr merged commit 27644f3 into juliusknorr:master Dec 5, 2023
20 checks passed
@juliusknorr
Copy link
Owner

Thanks a lot for that.

@juliusknorr
Copy link
Owner

Might be worth to extend the docs around that a bit as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance the unshallow functionality
2 participants