Start expecting some lints

juntyr · Jul 29, 2024 · e3b4ba3 · e3b4ba3
1 parent 3ff4ca1
commit e3b4ba3
Show file tree

Hide file tree

Showing 275 changed files with 435 additions and 599 deletions.
diff --git a/necsim/core/bond/src/closed_open_unit_f64.rs b/necsim/core/bond/src/closed_open_unit_f64.rs
@@ -10,7 +10,7 @@ use serde::{Deserialize, Serialize};
 use crate::ClosedUnitF64;
 
 #[derive(Debug)]
-#[allow(clippy::module_name_repetitions)]
+#[expect(clippy::module_name_repetitions)]
 pub struct ClosedOpenUnitF64Error(f64);
 
 impl fmt::Display for ClosedOpenUnitF64Error {
@@ -19,7 +19,7 @@ impl fmt::Display for ClosedOpenUnitF64Error {
     }
 }
 
-#[allow(clippy::unsafe_derive_deserialize)]
+#[expect(clippy::unsafe_derive_deserialize)]
 #[derive(Copy, Clone, Deserialize, Serialize, TypeLayout)]
 #[repr(transparent)]
 #[serde(try_from = "f64", into = "f64")]
@@ -88,7 +88,6 @@ impl ClosedOpenUnitF64 {
 }
 
 impl PartialEq for ClosedOpenUnitF64 {
-    #[allow(clippy::unconditional_recursion)]
     fn eq(&self, other: &Self) -> bool {
         self.0.eq(&other.0)
     }

diff --git a/necsim/core/bond/src/closed_unit_f64.rs b/necsim/core/bond/src/closed_unit_f64.rs
@@ -12,7 +12,7 @@ use serde::{Deserialize, Serialize};
 use crate::{ClosedOpenUnitF64, OpenClosedUnitF64};
 
 #[derive(Debug)]
-#[allow(clippy::module_name_repetitions)]
+#[expect(clippy::module_name_repetitions)]
 pub struct ClosedUnitF64Error(f64);
 
 impl fmt::Display for ClosedUnitF64Error {
@@ -21,7 +21,7 @@ impl fmt::Display for ClosedUnitF64Error {
     }
 }
 
-#[allow(clippy::unsafe_derive_deserialize)]
+#[expect(clippy::unsafe_derive_deserialize)]
 #[derive(Copy, Clone, Serialize, Deserialize, TypeLayout)]
 #[repr(transparent)]
 #[serde(try_from = "f64", into = "f64")]
@@ -122,7 +122,6 @@ impl From<ClosedOpenUnitF64> for ClosedUnitF64 {
 }
 
 impl PartialEq for ClosedUnitF64 {
-    #[allow(clippy::unconditional_recursion)]
     fn eq(&self, other: &Self) -> bool {
         self.0.eq(&other.0)
     }

diff --git a/necsim/core/bond/src/non_negative_f64.rs b/necsim/core/bond/src/non_negative_f64.rs
@@ -14,7 +14,7 @@ use necsim_core_maths::MathsCore;
 use crate::{ClosedOpenUnitF64, ClosedUnitF64, NonPositiveF64, OpenClosedUnitF64, PositiveF64};
 
 #[derive(Debug)]
-#[allow(clippy::module_name_repetitions)]
+#[expect(clippy::module_name_repetitions)]
 pub struct NonNegativeF64Error(f64);
 
 impl fmt::Display for NonNegativeF64Error {
@@ -23,7 +23,7 @@ impl fmt::Display for NonNegativeF64Error {
     }
 }
 
-#[allow(clippy::unsafe_derive_deserialize)]
+#[expect(clippy::unsafe_derive_deserialize)]
 #[derive(Copy, Clone, Serialize, Deserialize, TypeLayout)]
 #[repr(transparent)]
 #[serde(try_from = "f64", into = "f64")]
@@ -123,14 +123,14 @@ impl From<u32> for NonNegativeF64 {
 }
 
 impl From<u64> for NonNegativeF64 {
-    #[allow(clippy::cast_precision_loss)]
+    #[expect(clippy::cast_precision_loss)]
     fn from(value: u64) -> Self {
         Self(value as f64)
     }
 }
 
 impl From<usize> for NonNegativeF64 {
-    #[allow(clippy::cast_precision_loss)]
+    #[expect(clippy::cast_precision_loss)]
     fn from(value: usize) -> Self {
         Self(value as f64)
     }
@@ -161,7 +161,6 @@ impl From<ClosedOpenUnitF64> for NonNegativeF64 {
 }
 
 impl PartialEq for NonNegativeF64 {
-    #[allow(clippy::unconditional_recursion)]
     fn eq(&self, other: &Self) -> bool {
         self.0.eq(&other.0)
     }

diff --git a/necsim/core/bond/src/non_positive_f64.rs b/necsim/core/bond/src/non_positive_f64.rs
@@ -11,7 +11,7 @@ use serde::{Deserialize, Serialize};
 use crate::NonNegativeF64;
 
 #[derive(Debug)]
-#[allow(clippy::module_name_repetitions)]
+#[expect(clippy::module_name_repetitions)]
 pub struct NonPositiveF64Error(f64);
 
 impl fmt::Display for NonPositiveF64Error {
@@ -20,7 +20,7 @@ impl fmt::Display for NonPositiveF64Error {
     }
 }
 
-#[allow(clippy::unsafe_derive_deserialize)]
+#[expect(clippy::unsafe_derive_deserialize)]
 #[derive(Copy, Clone, Serialize, Deserialize, TypeLayout)]
 #[repr(transparent)]
 #[serde(try_from = "f64", into = "f64")]
@@ -94,7 +94,6 @@ impl NonPositiveF64 {
 }
 
 impl PartialEq for NonPositiveF64 {
-    #[allow(clippy::unconditional_recursion)]
     fn eq(&self, other: &Self) -> bool {
         self.0.eq(&other.0)
     }

diff --git a/necsim/core/bond/src/non_zero_one_u64.rs b/necsim/core/bond/src/non_zero_one_u64.rs
@@ -3,7 +3,7 @@ use core::{convert::TryFrom, fmt, num::NonZeroU64};
 use serde::{Deserialize, Deserializer, Serialize};
 
 #[derive(Debug)]
-#[allow(clippy::module_name_repetitions)]
+#[expect(clippy::module_name_repetitions)]
 pub struct NonZeroOneU64Error(u64);
 
 impl fmt::Display for NonZeroOneU64Error {

diff --git a/necsim/core/bond/src/off_by_one_u32.rs b/necsim/core/bond/src/off_by_one_u32.rs
@@ -7,7 +7,7 @@ use core::{
 use serde::{Deserialize, Deserializer, Serialize};
 
 #[derive(Debug)]
-#[allow(clippy::module_name_repetitions)]
+#[expect(clippy::module_name_repetitions)]
 pub struct OffByOneU32Error(u64);
 
 impl fmt::Display for OffByOneU32Error {
@@ -37,7 +37,7 @@ impl OffByOneU32 {
         //     Err(_) => Err(OffByOneU32Error(value)),
         // }
         match value.wrapping_sub(1) {
-            #[allow(clippy::cast_possible_truncation)]
+            #[expect(clippy::cast_possible_truncation)]
             value if value <= (u32::MAX as u64) => Ok(Self(value as u32)),
             _ => Err(OffByOneU32Error(value)),
         }
@@ -50,7 +50,7 @@ impl OffByOneU32 {
     ///
     /// The value must be in {1, .., 2^32}.
     pub const unsafe fn new_unchecked(value: u64) -> Self {
-        #[allow(clippy::cast_possible_truncation)]
+        #[expect(clippy::cast_possible_truncation)]
         Self(value.wrapping_sub(1) as u32)
     }
 

diff --git a/necsim/core/bond/src/off_by_one_u64.rs b/necsim/core/bond/src/off_by_one_u64.rs
@@ -10,7 +10,7 @@ use serde::{Deserialize, Deserializer, Serialize};
 use crate::{ClosedUnitF64, OffByOneU32};
 
 #[derive(Debug)]
-#[allow(clippy::module_name_repetitions)]
+#[expect(clippy::module_name_repetitions)]
 pub struct OffByOneU64Error(u128);
 
 impl fmt::Display for OffByOneU64Error {
@@ -40,7 +40,7 @@ impl OffByOneU64 {
         //     Err(_) => Err(OffByOneU64Error(value)),
         // }
         match value.wrapping_sub(1) {
-            #[allow(clippy::cast_possible_truncation)]
+            #[expect(clippy::cast_possible_truncation)]
             value if value < (u64::MAX as u128) => Ok(Self(value as u64)),
             _ => Err(OffByOneU64Error(value)),
         }
@@ -53,7 +53,7 @@ impl OffByOneU64 {
     ///
     /// The value must be in {1, .., 2^64}.
     pub const unsafe fn new_unchecked(value: u128) -> Self {
-        #[allow(clippy::cast_possible_truncation)]
+        #[expect(clippy::cast_possible_truncation)]
         Self(value.wrapping_sub(1) as u64)
     }
 
@@ -128,7 +128,7 @@ impl From<OffByOneU64> for NonZeroU64 {
 }
 
 impl From<OffByOneU64> for f64 {
-    #[allow(clippy::cast_precision_loss)]
+    #[expect(clippy::cast_precision_loss)]
     fn from(val: OffByOneU64) -> Self {
         (val.0 as f64) + 1.0_f64
     }
@@ -166,9 +166,9 @@ impl Mul<ClosedUnitF64> for OffByOneU64 {
     type Output = Self;
 
     fn mul(self, other: ClosedUnitF64) -> Self::Output {
-        #[allow(clippy::cast_possible_truncation)]
-        #[allow(clippy::cast_sign_loss)]
-        #[allow(clippy::cast_precision_loss)]
+        #[expect(clippy::cast_possible_truncation)]
+        #[expect(clippy::cast_sign_loss)]
+        #[expect(clippy::cast_precision_loss)]
         Self(((((self.get() as f64) * other.get()) as u128) - 1) as u64)
     }
 }
diff --git a/necsim/core/bond/src/open_closed_unit_f64.rs b/necsim/core/bond/src/open_closed_unit_f64.rs
@@ -11,7 +11,7 @@ use serde::{Deserialize, Serialize};
 use crate::NonPositiveF64;
 
 #[derive(Debug)]
-#[allow(clippy::module_name_repetitions)]
+#[expect(clippy::module_name_repetitions)]
 pub struct OpenClosedUnitF64Error(f64);
 
 impl fmt::Display for OpenClosedUnitF64Error {
@@ -20,7 +20,7 @@ impl fmt::Display for OpenClosedUnitF64Error {
     }
 }
 
-#[allow(clippy::unsafe_derive_deserialize)]
+#[expect(clippy::unsafe_derive_deserialize)]
 #[derive(Copy, Clone, Deserialize, Serialize, TypeLayout)]
 #[repr(transparent)]
 #[serde(try_from = "f64", into = "f64")]
@@ -94,7 +94,6 @@ impl OpenClosedUnitF64 {
 }
 
 impl PartialEq for OpenClosedUnitF64 {
-    #[allow(clippy::unconditional_recursion)]
     fn eq(&self, other: &Self) -> bool {
         self.0.eq(&other.0)
     }

diff --git a/necsim/core/bond/src/positive_f64.rs b/necsim/core/bond/src/positive_f64.rs
@@ -12,7 +12,7 @@ use serde::{Deserialize, Serialize};
 use crate::NonNegativeF64;
 
 #[derive(Debug)]
-#[allow(clippy::module_name_repetitions)]
+#[expect(clippy::module_name_repetitions)]
 pub struct PositiveF64Error(f64);
 
 impl fmt::Display for PositiveF64Error {
@@ -21,7 +21,7 @@ impl fmt::Display for PositiveF64Error {
     }
 }
 
-#[allow(clippy::unsafe_derive_deserialize)]
+#[expect(clippy::unsafe_derive_deserialize)]
 #[derive(Copy, Clone, Serialize, Deserialize, TypeLayout)]
 #[repr(transparent)]
 #[serde(try_from = "f64", into = "f64")]
@@ -120,14 +120,13 @@ impl From<NonZeroU32> for PositiveF64 {
 }
 
 impl From<NonZeroU64> for PositiveF64 {
-    #[allow(clippy::cast_precision_loss)]
+    #[expect(clippy::cast_precision_loss)]
     fn from(value: NonZeroU64) -> Self {
         Self(value.get() as f64)
     }
 }
 
 impl PartialEq for PositiveF64 {
-    #[allow(clippy::unconditional_recursion)]
     fn eq(&self, other: &Self) -> bool {
         self.0.eq(&other.0)
     }

diff --git a/necsim/core/src/cogs/active_lineage_sampler.rs b/necsim/core/src/cogs/active_lineage_sampler.rs
@@ -9,8 +9,6 @@ use super::{
 
 use crate::{lineage::Lineage, simulation::partial::active_lineage_sampler::PartialSimulation};
 
-#[allow(clippy::inline_always, clippy::inline_fn_without_body)]
-#[allow(clippy::no_effect_underscore_binding)]
 #[contract_trait]
 pub trait ActiveLineageSampler<
     M: MathsCore,

diff --git a/necsim/core/src/cogs/backup.rs b/necsim/core/src/cogs/backup.rs
@@ -1,6 +1,5 @@
 use core::ops::Deref;
 
-#[allow(clippy::inline_always, clippy::inline_fn_without_body)]
 #[contract_trait]
 pub trait Backup: Sized {
     #[must_use]

diff --git a/necsim/core/src/cogs/coalescence_sampler.rs b/necsim/core/src/cogs/coalescence_sampler.rs
@@ -12,7 +12,6 @@ use crate::{
 
 use super::{Habitat, LineageStore};
 
-#[allow(clippy::inline_always, clippy::inline_fn_without_body)]
 #[contract_trait]
 pub trait CoalescenceSampler<M: MathsCore, H: Habitat<M>, S: LineageStore<M, H>>:
     crate::cogs::Backup + core::fmt::Debug
@@ -68,11 +67,7 @@ impl CoalescenceRngSample {
     pub fn sample_coalescence_index<M: MathsCore>(self, length: u32) -> u32 {
         // attributes on expressions are experimental
         // see https://github.com/rust-lang/rust/issues/15701
-        #[allow(
-            clippy::cast_precision_loss,
-            clippy::cast_possible_truncation,
-            clippy::cast_sign_loss
-        )]
+        #[expect(clippy::cast_possible_truncation, clippy::cast_sign_loss)]
         let index = M::floor(self.0.get() * f64::from(length)) as u32;
         index
     }

diff --git a/necsim/core/src/cogs/dispersal_sampler.rs b/necsim/core/src/cogs/dispersal_sampler.rs
@@ -7,9 +7,6 @@ use crate::{
 
 use super::Habitat;
 
-#[allow(clippy::inline_always, clippy::inline_fn_without_body)]
-#[allow(clippy::no_effect_underscore_binding)]
-#[allow(clippy::module_name_repetitions)]
 #[contract_trait]
 pub trait DispersalSampler<M: MathsCore, H: Habitat<M>, G: RngCore<M>>:
     crate::cogs::Backup + core::fmt::Debug
@@ -25,9 +22,7 @@ pub trait DispersalSampler<M: MathsCore, H: Habitat<M>, G: RngCore<M>>:
     ) -> Location;
 }
 
-#[allow(clippy::inline_always, clippy::inline_fn_without_body)]
-#[allow(clippy::no_effect_underscore_binding)]
-#[allow(clippy::module_name_repetitions)]
+#[expect(clippy::module_name_repetitions)]
 #[contract_trait]
 pub trait SeparableDispersalSampler<M: MathsCore, H: Habitat<M>, G: RngCore<M>>:
     DispersalSampler<M, H, G>

diff --git a/necsim/core/src/cogs/emigration_exit.rs b/necsim/core/src/cogs/emigration_exit.rs
@@ -7,12 +7,7 @@ use crate::{
     simulation::partial::emigration_exit::PartialSimulation,
 };
 
-#[allow(
-    clippy::inline_always,
-    clippy::inline_fn_without_body,
-    clippy::too_many_arguments
-)]
-#[allow(clippy::no_effect_underscore_binding)]
+#[expect(clippy::too_many_arguments)]
 #[contract_trait]
 pub trait EmigrationExit<M: MathsCore, H: Habitat<M>, G: RngCore<M>, S: LineageStore<M, H>>:
     crate::cogs::Backup + core::fmt::Debug

diff --git a/necsim/core/src/cogs/event_sampler.rs b/necsim/core/src/cogs/event_sampler.rs
@@ -16,7 +16,6 @@ pub struct EventHandler<S, D, E> {
     pub emigration: E,
 }
 
-#[allow(clippy::inline_always, clippy::inline_fn_without_body)]
 #[contract_trait]
 pub trait EventSampler<
     M: MathsCore,

diff --git a/necsim/core/src/cogs/habitat.rs b/necsim/core/src/cogs/habitat.rs
@@ -4,11 +4,6 @@ use crate::landscape::{IndexedLocation, LandscapeExtent, Location};
 
 use super::{MathsCore, RngCore};
 
-#[allow(
-    clippy::inline_always,
-    clippy::inline_fn_without_body,
-    clippy::no_effect_underscore_binding
-)]
 #[contract_trait]
 pub trait Habitat<M: MathsCore>: crate::cogs::Backup + core::fmt::Debug + Sized {
     type LocationIterator<'a>: Iterator<Item = Location> + 'a
@@ -60,12 +55,7 @@ pub trait Habitat<M: MathsCore>: crate::cogs::Backup + core::fmt::Debug + Sized
     fn iter_habitable_locations(&self) -> Self::LocationIterator<'_>;
 }
 
-#[allow(clippy::module_name_repetitions)]
-#[allow(
-    clippy::inline_always,
-    clippy::inline_fn_without_body,
-    clippy::no_effect_underscore_binding
-)]
+#[expect(clippy::module_name_repetitions)]
 #[contract_trait]
 pub trait UniformlySampleableHabitat<M: MathsCore, G: RngCore<M>>: Habitat<M> {
     #[debug_ensures(

diff --git a/necsim/core/src/cogs/immigration_entry.rs b/necsim/core/src/cogs/immigration_entry.rs
@@ -2,7 +2,6 @@ use crate::lineage::MigratingLineage;
 
 use super::MathsCore;
 
-#[allow(clippy::inline_always, clippy::inline_fn_without_body)]
 #[contract_trait]
 pub trait ImmigrationEntry<M: MathsCore>: crate::cogs::Backup + core::fmt::Debug {
     #[must_use]

diff --git a/necsim/core/src/cogs/lineage_reference.rs b/necsim/core/src/cogs/lineage_reference.rs
@@ -2,7 +2,6 @@ use core::hash::Hash;
 
 use super::{Habitat, MathsCore};
 
-#[allow(clippy::module_name_repetitions)]
 pub trait LineageReference<M: MathsCore, H: Habitat<M>>:
     crate::cogs::Backup + PartialEq + Eq + Hash + core::fmt::Debug
 {