-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive vector tile layers #1213
Merged
martinRenou
merged 13 commits into
jupyter-widgets:master
from
lopezvoliver:vtl_renderer
Jul 22, 2024
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f19044a
Add renderer_factory option
lopezvoliver 6ffcaef
Update docstring for interactive, default False
lopezvoliver 66e6a92
Optional get_feature_id
lopezvoliver fd30835
Send propagatedForm properties and options
lopezvoliver c20ba8f
Add set_feature_style and reset_feature_style
lopezvoliver 56b56b9
feature_style as traitlets property
lopezvoliver 44c5099
setOpacity to 0 if VTL initialized with visible=False
lopezvoliver 65b1fbf
Rename vector_tile_layer_styles to layer_styles in python
lopezvoliver 4b0320d
Rename renderer_factory to renderer in python
lopezvoliver 8376c74
Rename get_feature_id to feature_id in python
lopezvoliver aaf6020
backwards compatibility for vector_tile_layer_styles
lopezvoliver d3c87a5
Backwards compatiblity and update layer_styles
lopezvoliver aa1da08
Merge branch 'master' into vtl_renderer
martinRenou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be backward compatible only at the layer creation.
I see three options here:
vector_tile_layer_styles
?If yes:
@vector_tile_layer_styles.setter def set_vector_tile_layer_styles
I'd prefer one of the two first options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martinRenou
I went ahead with option 2:
vector_tile_layer_styles
is backwards compatible, and it uses a setter that updateslayer_styles
.Regarding the ability to update styles after initialization -- this wasn't contemplated in #1206, so I also fixed this by adding a listener to
layer_styles
.Here's a demo of the new capabilities: