Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

[WIP] [Issue: 50] Backslashes in Windows paths need to be escaped #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] [Issue: 50] Backslashes in Windows paths need to be escaped #54

wants to merge 1 commit into from

Conversation

nitind
Copy link
Member

@nitind nitind commented Aug 16, 2016

Skip calling abspath and the normalization that turns \\ into \
on Windows.

(c) Copyright IBM Corp. 2016

    Skip calling abspath and the normalization that turns \\ into \
(c) Copyright IBM Corp. 2016
@nitind
Copy link
Member Author

nitind commented Aug 16, 2016

For #50 .

Removing the abspath call as it forces normalization. While there is technically some risk involved on Python<3.4 if the extension is part of the PYTHONPATH using a relative path, I think it's more important that the paths returned from the Python libraries on Windows that already contain the required double-backslashes be kept intact.

@nitind nitind changed the title [Issue: 50] Backslashes in Windows paths need to be escaped [WIP] [Issue: 50] Backslashes in Windows paths need to be escaped Aug 16, 2016
@rs2
Copy link

rs2 commented Aug 22, 2016

OK to merge?

@nitind
Copy link
Member Author

nitind commented Aug 22, 2016

@rs2 Were you able to successfully test the change?

@rs2
Copy link

rs2 commented Aug 23, 2016

👎 Sorry. Still raise IOError(\'template file "%s" could not be found\' % self.template_file)\r\nOSError: template file "index.html.tpl" could not be found\r\n'

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants