Add the file filter button to the file browser toolbar #2130
Annotations
8 errors and 2 notices
Update snapshots:
ui-tests/test/filebrowser.spec.ts#L39
1) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Download')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Download')
37 |
38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
> 39 | expect(toolbar.getByText(text)).toBeVisible();
| ^
40 | });
41 | });
42 |
at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39)
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
|
Update snapshots:
ui-tests/test/filebrowser.spec.ts#L55
2) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ───────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
53 | expect(toolbar.getByText('Rename')).toBeHidden();
54 | expect(toolbar.getByText('Open')).toBeHidden();
> 55 | expect(toolbar.getByText('Delete')).toBeVisible();
| ^
56 | });
57 |
58 | test('Select files and open', async ({ page, tmpPath }) => {
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
|
Test:
ui-tests/test/settings.spec.ts#L45
1) [firefox] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page
Error: Screenshot comparison failed:
350 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts-snapshots/top-visible-firefox-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-firefox/top-visible-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-firefox/top-visible-diff.png
43 | await page.reload({ waitUntil: 'networkidle' });
44 | await page.menu.getMenuItem(showHeaderPath);
> 45 | expect(await page.screenshot()).toMatchSnapshot('top-visible.png', {
| ^
46 | maxDiffPixels: 300,
47 | });
48 | });
at /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts:45:37
|
Test:
ui-tests/test/settings.spec.ts#L45
1) [firefox] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
550 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts-snapshots/top-visible-firefox-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-firefox-retry1/top-visible-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-firefox-retry1/top-visible-diff.png
43 | await page.reload({ waitUntil: 'networkidle' });
44 | await page.menu.getMenuItem(showHeaderPath);
> 45 | expect(await page.screenshot()).toMatchSnapshot('top-visible.png', {
| ^
46 | maxDiffPixels: 300,
47 | });
48 | });
at /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts:45:37
|
Test:
ui-tests/test/filebrowser.spec.ts#L28
2) [firefox] › test/filebrowser.spec.ts:20:7 › File Browser › Select one folder ──────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
26 |
27 | expect(toolbar.getByText('Rename')).toBeVisible();
> 28 | expect(toolbar.getByText('Delete')).toBeVisible();
| ^
29 | });
30 |
31 | test('Select one file', async ({ page, tmpPath }) => {
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:28:41
|
Test:
ui-tests/test/filebrowser.spec.ts#L39
3) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
37 |
38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
> 39 | expect(toolbar.getByText(text)).toBeVisible();
| ^
40 | });
41 | });
42 |
at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39)
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
|
Test:
ui-tests/test/mobile.spec.ts#L38
4) [firefox] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page
Error: Screenshot comparison failed:
487 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/tree-firefox-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-firefox/tree-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-firefox/tree-diff.png
36 | await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' });
37 |
> 38 | expect(await page.screenshot()).toMatchSnapshot('tree.png', {
| ^
39 | maxDiffPixels: 300,
40 | });
41 | });
at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:38:37
|
Test
Process completed with exit code 1.
|
Update snapshots
2 flaky
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ─────────────────────
[firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ────────────
33 passed (1.9m)
|
Test
1 failed
[firefox] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page
3 flaky
[firefox] › test/filebrowser.spec.ts:20:7 › File Browser › Select one folder ───────────────────
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ─────────────────────
[firefox] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page
31 passed (2.3m)
|
Loading