Skip to content

Enable single click by default in the file browser #2137

Enable single click by default in the file browser

Enable single click by default in the file browser #2137

Triggered via pull request October 15, 2024 19:50
Status Success
Total duration 8m 38s
Artifacts 6

ui-tests.yml

on: pull_request
Matrix: ui-tests
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 2 notices
[firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders: ui-tests/test/filebrowser.spec.ts#L55
1) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ─────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Delete') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Delete') 53 | expect(toolbar.getByText('Rename')).toBeHidden(); 54 | expect(toolbar.getByText('Open')).toBeHidden(); > 55 | expect(toolbar.getByText('Delete')).toBeVisible(); | ^ 56 | }); 57 | 58 | test('Select files and open', async ({ page, tmpPath }) => { at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
[firefox] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered: ui-tests/test/notebook.spec.ts#L1
2) [firefox] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ────────────────── Error: "apiRequestContext.fetch: Target page, context or browser has been closed Call log: - → GET http://localhost:8888/api/sessions?1729022242452 - user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0 - accept: */* - accept-encoding: gzip, deflate, br, zstd - host: localhost:8888 - accept-language: en-US - referer: http://localhost:8888/notebooks/test-notebook-Notebook-Title-should-be-rendered-firefox/example.ipynb - x-xsrftoken: 2|ea11b56d|bd2e1ac86bebcf487247b02ce128085d|1729022239 - content-type: application/json - sec-fetch-dest: empty - sec-fetch-mode: cors - sec-fetch-site: same-origin - connection: keep-alive - cookie: username-localhost-8888="2|1:0|10:1729022239|23:username-localhost-8888|200:eyJ1c2VybmFtZSI6ICJmYWE2N2M0ZGJkM2Q0ZWNhOWVkM2Y0Mjc2ZjVhNGI2OSIsICJuYW1lIjogIkFub255bW91cyBPcnRob3NpZSIsICJkaXNwbGF5X25hbWUiOiAiQW5vbnltb3VzIE9ydGhvc2llIiwgImluaXRpYWxzIjogIkFPIiwgImNvbG9yIjogbnVsbH0=|86022f73b5124b4733741e3a25bb179d02bc9064fa948c1798994fbca239da01"; _xsrf=2|ea11b56d|bd2e1ac86bebcf487247b02ce128085d|1729022239 " while running route callback. Consider awaiting `await page.unrouteAll({ behavior: 'ignoreErrors' })` before the end of the test to ignore remaining routes in flight. at /home/runner/work/notebook/notebook/ui-tests/node_modules/@jupyterlab/galata/src/galata.ts:891:51
[firefox] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered: ui-tests/test/notebook.spec.ts#L1
2) [firefox] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ────────────────── Error: Test ended. Browser logs: [pid=5258][err] *** You are running in headless mode. [pid=5258][err] JavaScript warning: resource://services-settings/Utils.sys.mjs, line 114: unreachable code after return statement [pid=5258][out] console.warn: services.settings: Ignoring preference override of remote settings server [pid=5258][out] console.warn: services.settings: Allow by setting MOZ_REMOTE_SETTINGS_DEVTOOLS=1 in the environment [pid=5258][out] Crash Annotation GraphicsCriticalError: |[0][GFX1-]: glxtest: Unable to open a connection to the X server (t=0.261503) [GFX1-]: glxtest: Unable to open a connection to the X server [pid=5258][out] console.error: ({}) [pid=5258][out] [pid=5258][out] Juggler listening to the pipe [pid=5258][out] console.error: ({}) [pid=5258][out] console.error: SearchEngineSelector: "Received empty search configuration!" [pid=5258][out] console.error: "Received empty top sites configuration!" [pid=5258][out] console.error: SearchEngineSelector: "Received empty search configuration!" [pid=5258][out] console.error: SearchService: "#init: failure initializing search:" ({}) [pid=5258][out] console.error: "Received empty top sites configuration!" [pid=5258][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 73: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings [pid=5258][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 73: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings [pid=5258][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 73: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings [pid=5258][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 73: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings [pid=5258][out] console.error: WebExtensions: [pid=5258][out] Message: [Exception... "Failed to get engine data from Remote Settings" nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)" location: "JS frame :: resource://gre/modules/SearchEngineSelector.sys.mjs :: getEngineConfiguration :: line 73" data: no] [pid=5258][out] Stack: [pid=5258][out] getEngineConfiguration@resource://gre/modules/SearchEngineSelector.sys.mjs:73:24 [pid=5258][out] [pid=5258][out] console.error: URLBar - Provider.UrlbarProviderSearchTips: ({}) [pid=5258][out] console.error: SearchSettings: "_write: Could not write to settings file:" (new Error("cannot write without any engine.", "resource://gre/modules/SearchSettings.sys.mjs", 303)) [pid=5258][err] JavaScript error: http://localhost:8888/static/notebook/5573.bundle.js, line 1: TypeError: s is undefined [pid=5258][err] JavaScript error: http://localhost:8888/static/notebook/5573.bundle.js, line 1: TypeError: s is undefined [pid=5258][err] JavaScript error: chrome://juggler/content/Helper.js, line 82: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebProgress.removeProgressListener] [pid=5258][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 73: NS_ERROR_UNEXPECTED: Failed to get engine data from Remote Settings [pid=5258][out] console.error: URLBar - Provider.UrlbarProviderSearchTips: ({}) [pid=5258][err] JavaScript error: http://localhost:8888/static/notebook/5573.bundle.js, line 1: TypeError: s is undefined [pid=5258][err] JavaScript error: http://localhost:8888/static/notebook/5573.bundle.js, line 1: TypeError: s is undefined [pid=5258][err] JavaScript error: chrome://juggler/content/Helper.js, line 82: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebProgress.removeProgressListener] [pid=5258][err] JavaScript error: resource://gre/modules/SearchEngineSelector.sys.mjs, line 73: NS_ERROR_UNEXPECTED: Failed to get engine data from Re
[chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory: ui-tests/test/links.spec.ts#L1
1) [chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory ─────────────── Test timeout of 60000ms exceeded.
[chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory: ui-tests/test/links.spec.ts#L25
1) [chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory ─────────────── Error: proxy.waitForEvent: Test timeout of 60000ms exceeded. =========================== logs =========================== waiting for event "popup" ============================================================ 23 | 24 | const [current] = await Promise.all([ > 25 | page.waitForEvent('popup'), | ^ 26 | page.getByText('Current Directory').last().click(), 27 | ]); 28 | at /home/runner/work/notebook/notebook/ui-tests/test/links.spec.ts:25:12
[chromium] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered: ui-tests/test/notebook.spec.ts#L1
2) [chromium] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ───────────────── Error: "apiRequestContext.fetch: Target page, context or browser has been closed Call log: - → POST http://localhost:8888/api/sessions?1729022247105 - user-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/128.0.6613.18 Safari/537.36 - accept: */* - accept-encoding: gzip,deflate,br - accept-language: en-US - content-type: text/plain;charset=UTF-8 - cookie: username-localhost-8888="2|1:0|10:1729022244|23:username-localhost-8888|192:eyJ1c2VybmFtZSI6ICIxYmEyZWE3MGQ1NjQ0NjUzOTg4NmFjOTc2YTNkNmU2YSIsICJuYW1lIjogIkFub255bW91cyBBcmNoZSIsICJkaXNwbGF5X25hbWUiOiAiQW5vbnltb3VzIEFyY2hlIiwgImluaXRpYWxzIjogIkFBIiwgImNvbG9yIjogbnVsbH0=|5a460eac9f0ef3800421c6c853c68a22960b947a9a1334c234400976ae4ab0ce"; _xsrf=2|b84a5cf2|a2102f305f2cd36998612dbf8545c6be|1729022244 - origin: http://localhost:8888 - referer: http://localhost:8888/notebooks/test-notebook-Notebook-Title-should-be-rendered-chromium/example.ipynb - x-xsrftoken: 2|b84a5cf2|a2102f305f2cd36998612dbf8545c6be|1729022244 - sec-ch-ua: "Chromium";v="128", "Not;A=Brand";v="24", "HeadlessChrome";v="128" - sec-ch-ua-mobile: ?0 - sec-ch-ua-platform: "Linux" - content-length: 173 " while running route callback. Consider awaiting `await page.unrouteAll({ behavior: 'ignoreErrors' })` before the end of the test to ignore remaining routes in flight. at /home/runner/work/notebook/notebook/ui-tests/node_modules/@jupyterlab/galata/src/galata.ts:961:49
[chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page: ui-tests/test/settings.spec.ts#L36
3) [chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page Error: Screenshot comparison failed: 489 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts-snapshots/top-hidden-chromium-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium/top-hidden-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium/top-hidden-diff.png 34 | await page.reload({ waitUntil: 'networkidle' }); 35 | await page.menu.getMenuItem(showHeaderPath); > 36 | expect(await page.screenshot()).toMatchSnapshot('top-hidden.png', { | ^ 37 | maxDiffPixels: 300, 38 | }); 39 | at /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts:36:37
🎭 Playwright Run Summary
2 flaky [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ──────────── [firefox] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ─────────────────── 33 passed (2.1m)
🎭 Playwright Run Summary
3 flaky [chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory ──────────────── [chromium] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ────────────────── [chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page 32 passed (2.3m)

Artifacts

Produced during runtime
Name Size
notebook-chromium-test-assets
5.46 MB
notebook-chromium-test-report
6.13 MB
notebook-dist-2137
9.5 MB
notebook-firefox-test-assets
3.02 MB
notebook-firefox-test-report
3.68 MB
notebook-pkgs-2137
57 KB