Move handling of the file browser settings to a separate plugin, enable file browser single click navigation #2138
Annotations
5 errors and 2 notices
Test:
ui-tests/test/mobile.spec.ts#L38
1) [chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page
Error: Screenshot comparison failed:
1601 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/tree-chromium-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-chromium/tree-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-chromium/tree-diff.png
36 | await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' });
37 |
> 38 | expect(await page.screenshot()).toMatchSnapshot('tree.png', {
| ^
39 | maxDiffPixels: 300,
40 | });
41 | });
at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:38:37
|
Test:
ui-tests/test/mobile.spec.ts#L38
1) [chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
1574 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/tree-chromium-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-chromium-retry1/tree-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-chromium-retry1/tree-diff.png
36 | await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' });
37 |
> 38 | expect(await page.screenshot()).toMatchSnapshot('tree.png', {
| ^
39 | maxDiffPixels: 300,
40 | });
41 | });
at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:38:37
|
Test:
ui-tests/test/settings.spec.ts#L36
2) [chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page
Error: Screenshot comparison failed:
2889 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts-snapshots/top-hidden-chromium-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium/top-hidden-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium/top-hidden-diff.png
34 | await page.reload({ waitUntil: 'networkidle' });
35 | await page.menu.getMenuItem(showHeaderPath);
> 36 | expect(await page.screenshot()).toMatchSnapshot('top-hidden.png', {
| ^
37 | maxDiffPixels: 300,
38 | });
39 |
at /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts:36:37
|
Test:
ui-tests/test/settings.spec.ts#L36
2) [chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
2889 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts-snapshots/top-hidden-chromium-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium-retry1/top-hidden-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium-retry1/top-hidden-diff.png
34 | await page.reload({ waitUntil: 'networkidle' });
35 | await page.menu.getMenuItem(showHeaderPath);
> 36 | expect(await page.screenshot()).toMatchSnapshot('top-hidden.png', {
| ^
37 | maxDiffPixels: 300,
38 | });
39 |
at /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts:36:37
|
Test
Process completed with exit code 1.
|
Update snapshots
35 passed (1.7m)
|
Test
2 failed
[chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page
[chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page
33 passed (1.9m)
|
Loading