Move handling of the file browser settings to a separate plugin, enable file browser single click navigation #2139
Annotations
13 errors and 2 notices
|
Update snapshots:
ui-tests/test/filebrowser.spec.ts#L39
1) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Open')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Open')
37 |
38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
> 39 | expect(toolbar.getByText(text)).toBeVisible();
| ^
40 | });
41 | });
42 |
at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39)
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
|
Update snapshots:
ui-tests/test/filebrowser.spec.ts#L55
2) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ───────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
53 | expect(toolbar.getByText('Rename')).toBeHidden();
54 | expect(toolbar.getByText('Open')).toBeHidden();
> 55 | expect(toolbar.getByText('Delete')).toBeVisible();
| ^
56 | });
57 |
58 | test('Select files and open', async ({ page, tmpPath }) => {
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
|
Update snapshots:
ui-tests/test/links.spec.ts#L1
3) [firefox] › test/links.spec.ts:21:7 › Local Links › Open the current directory ────────────────
Test timeout of 60000ms exceeded.
|
Update snapshots:
ui-tests/test/links.spec.ts#L25
3) [firefox] › test/links.spec.ts:21:7 › Local Links › Open the current directory ────────────────
Error: proxy.waitForEvent: Test timeout of 60000ms exceeded.
=========================== logs ===========================
waiting for event "popup"
============================================================
23 |
24 | const [current] = await Promise.all([
> 25 | page.waitForEvent('popup'),
| ^
26 | page.getByText('Current Directory').last().click(),
27 | ]);
28 |
at /home/runner/work/notebook/notebook/ui-tests/test/links.spec.ts:25:12
|
Update snapshots
The operation was canceled.
|
Test:
ui-tests/test/mobile.spec.ts#L38
1) [firefox] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page
Error: Screenshot comparison failed:
1626 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/tree-firefox-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-firefox/tree-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-firefox/tree-diff.png
36 | await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' });
37 |
> 38 | expect(await page.screenshot()).toMatchSnapshot('tree.png', {
| ^
39 | maxDiffPixels: 300,
40 | });
41 | });
at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:38:37
|
Test:
ui-tests/test/mobile.spec.ts#L38
1) [firefox] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
1626 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/tree-firefox-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-firefox-retry1/tree-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-firefox-retry1/tree-diff.png
36 | await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' });
37 |
> 38 | expect(await page.screenshot()).toMatchSnapshot('tree.png', {
| ^
39 | maxDiffPixels: 300,
40 | });
41 | });
at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:38:37
|
Test:
ui-tests/test/settings.spec.ts#L36
2) [firefox] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page
Error: Screenshot comparison failed:
2976 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts-snapshots/top-hidden-firefox-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-firefox/top-hidden-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-firefox/top-hidden-diff.png
34 | await page.reload({ waitUntil: 'networkidle' });
35 | await page.menu.getMenuItem(showHeaderPath);
> 36 | expect(await page.screenshot()).toMatchSnapshot('top-hidden.png', {
| ^
37 | maxDiffPixels: 300,
38 | });
39 |
at /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts:36:37
|
Test:
ui-tests/test/settings.spec.ts#L36
2) [firefox] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
2976 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts-snapshots/top-hidden-firefox-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-firefox-retry1/top-hidden-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-firefox-retry1/top-hidden-diff.png
34 | await page.reload({ waitUntil: 'networkidle' });
35 | await page.menu.getMenuItem(showHeaderPath);
> 36 | expect(await page.screenshot()).toMatchSnapshot('top-hidden.png', {
| ^
37 | maxDiffPixels: 300,
38 | });
39 |
at /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts:36:37
|
Test:
ui-tests/test/filebrowser.spec.ts#L39
3) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Download')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Download')
37 |
38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
> 39 | expect(toolbar.getByText(text)).toBeVisible();
| ^
40 | });
41 | });
42 |
at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39)
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
|
Test:
ui-tests/test/filebrowser.spec.ts#L55
4) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ───────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
53 | expect(toolbar.getByText('Rename')).toBeHidden();
54 | expect(toolbar.getByText('Open')).toBeHidden();
> 55 | expect(toolbar.getByText('Delete')).toBeVisible();
| ^
56 | });
57 |
58 | test('Select files and open', async ({ page, tmpPath }) => {
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
|
Test
Process completed with exit code 1.
|
Update snapshots
3 flaky
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ─────────────────────
[firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ────────────
[firefox] › test/links.spec.ts:21:7 › Local Links › Open the current directory ─────────────────
32 passed (2.4m)
|
Test
2 failed
[firefox] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page
[firefox] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page
2 flaky
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ─────────────────────
[firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ────────────
31 passed (2.3m)
|
Loading