Add a setting to enable the notebook to take up the full width #2147
Annotations
7 errors and 2 notices
Update snapshots:
ui-tests/test/notebook.spec.ts#L1
1) [chromium] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ─────────────────
Error: "apiRequestContext.fetch: Target page, context or browser has been closed
Call log:
- → POST http://localhost:8888/api/sessions?1729621685399
- user-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/128.0.6613.18 Safari/537.36
- accept: */*
- accept-encoding: gzip,deflate,br
- accept-language: en-US
- content-type: text/plain;charset=UTF-8
- cookie: username-localhost-8888="2|1:0|10:1729621682|23:username-localhost-8888|196:eyJ1c2VybmFtZSI6ICIyNDlmN2FmZGM2N2M0Zjk3ODU2NGFhMDMzYjI1YjcwZCIsICJuYW1lIjogIkFub255bW91cyBTaW5vcGUiLCAiZGlzcGxheV9uYW1lIjogIkFub255bW91cyBTaW5vcGUiLCAiaW5pdGlhbHMiOiAiQVMiLCAiY29sb3IiOiBudWxsfQ==|fb03ba0ac2bad03df3426cf49029c20d00a1d95a0429a9c7e9de3d011d4fb692"; _xsrf=2|1001264d|e58c301688668f56fa68002b85dfdef3|1729621682
- origin: http://localhost:8888
- referer: http://localhost:8888/notebooks/test-notebook-Notebook-Title-should-be-rendered-chromium/example.ipynb
- x-xsrftoken: 2|1001264d|e58c301688668f56fa68002b85dfdef3|1729621682
- sec-ch-ua: "Chromium";v="128", "Not;A=Brand";v="24", "HeadlessChrome";v="128"
- sec-ch-ua-mobile: ?0
- sec-ch-ua-platform: "Linux"
- content-length: 173
" while running route callback.
Consider awaiting `await page.unrouteAll({ behavior: 'ignoreErrors' })`
before the end of the test to ignore remaining routes in flight.
at /home/runner/work/notebook/notebook/ui-tests/node_modules/@jupyterlab/galata/src/galata.ts:961:49
|
Test:
ui-tests/test/menus.spec.ts#L47
1) [chromium] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View ───────────────────
Error: Screenshot comparison failed:
Expected an image 369px by 648px, received 369px by 672px. 7213 pixels (ratio 0.03 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-view-chromium-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-chromium/opened-menu-view-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-chromium/opened-menu-view-diff.png
45 | const menu = await page.menu.getOpenMenu();
46 | expect(menu).toBeDefined();
> 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase());
| ^
48 | });
49 | });
50 | });
at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
|
Test:
ui-tests/test/menus.spec.ts#L47
1) [chromium] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View ───────────────────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
Expected an image 369px by 648px, received 369px by 672px. 7213 pixels (ratio 0.03 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-view-chromium-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-chromium-retry1/opened-menu-view-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-chromium-retry1/opened-menu-view-diff.png
45 | const menu = await page.menu.getOpenMenu();
46 | expect(menu).toBeDefined();
> 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase());
| ^
48 | });
49 | });
50 | });
at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
|
Test:
ui-tests/test/settings.spec.ts#L36
2) [chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page
Error: Screenshot comparison failed:
489 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts-snapshots/top-hidden-chromium-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium/top-hidden-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium/top-hidden-diff.png
34 | await page.reload({ waitUntil: 'networkidle' });
35 | await page.menu.getMenuItem(showHeaderPath);
> 36 | expect(await page.screenshot()).toMatchSnapshot('top-hidden.png', {
| ^
37 | maxDiffPixels: 300,
38 | });
39 |
at /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts:36:37
|
Test:
ui-tests/test/settings.spec.ts#L36
2) [chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
489 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts-snapshots/top-hidden-chromium-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium-retry1/top-hidden-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium-retry1/top-hidden-diff.png
34 | await page.reload({ waitUntil: 'networkidle' });
35 | await page.menu.getMenuItem(showHeaderPath);
> 36 | expect(await page.screenshot()).toMatchSnapshot('top-hidden.png', {
| ^
37 | maxDiffPixels: 300,
38 | });
39 |
at /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts:36:37
|
Test:
ui-tests/test/mobile.spec.ts#L38
3) [chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page
Error: Screenshot comparison failed:
405 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/tree-chromium-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-chromium/tree-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-chromium/tree-diff.png
36 | await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' });
37 |
> 38 | expect(await page.screenshot()).toMatchSnapshot('tree.png', {
| ^
39 | maxDiffPixels: 300,
40 | });
41 | });
at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:38:37
|
Test
Process completed with exit code 1.
|
Update snapshots
1 flaky
[chromium] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ──────────────────
34 passed (1.8m)
|
Test
2 failed
[chromium] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View ────────────────────
[chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page
1 flaky
[chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page
32 passed (2.0m)
|
Loading