Skip to content

Add a setting to enable the notebook to take up the full width #2152

Add a setting to enable the notebook to take up the full width

Add a setting to enable the notebook to take up the full width #2152

Triggered via pull request October 23, 2024 06:46
Status Failure
Total duration 9m 38s
Artifacts 7

ui-tests.yml

on: pull_request
Matrix: ui-tests
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 3 notices
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file: ui-tests/test/filebrowser.spec.ts#L39
1) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ──────────────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Delete') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Delete') 37 | 38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => { > 39 | expect(toolbar.getByText(text)).toBeVisible(); | ^ 40 | }); 41 | }); 42 | at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39) at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
[firefox] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered: ui-tests/test/notebook.spec.ts#L1
2) [firefox] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ────────────────── Error: "apiRequestContext.fetch: Target page, context or browser has been closed Call log: - → POST http://localhost:8888/api/sessions?1729666428712 - user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0 - accept: */* - accept-encoding: gzip, deflate, br, zstd - host: localhost:8888 - accept-language: en-US - content-type: text/plain;charset=UTF-8 - content-length: 172 - referer: http://localhost:8888/notebooks/test-notebook-Notebook-Title-should-be-rendered-firefox/example.ipynb - x-xsrftoken: 2|915cc9b5|d95b71334da88d17f9f3bfb6b268eacb|1729666425 - origin: http://localhost:8888 - sec-fetch-dest: empty - sec-fetch-mode: cors - sec-fetch-site: same-origin - connection: keep-alive - cookie: username-localhost-8888="2|1:0|10:1729666425|23:username-localhost-8888|196:eyJ1c2VybmFtZSI6ICI0NzFmNDkzZTQ2NTA0MWNiYTAyNThlNmVkMmYzYzU5NiIsICJuYW1lIjogIkFub255bW91cyBFdXJvcGEiLCAiZGlzcGxheV9uYW1lIjogIkFub255bW91cyBFdXJvcGEiLCAiaW5pdGlhbHMiOiAiQUUiLCAiY29sb3IiOiBudWxsfQ==|e9c9985b39851144dea14a0d287c5a01ef6346670f3c5cb8f075603dfd9eaa8f"; _xsrf=2|915cc9b5|d95b71334da88d17f9f3bfb6b268eacb|1729666425 " while running route callback. Consider awaiting `await page.unrouteAll({ behavior: 'ignoreErrors' })` before the end of the test to ignore remaining routes in flight. at /home/runner/work/notebook/notebook/ui-tests/node_modules/@jupyterlab/galata/src/galata.ts:961:49
[chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page: ui-tests/test/settings.spec.ts#L36
1) [chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page Error: Screenshot comparison failed: 489 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts-snapshots/top-hidden-chromium-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium/top-hidden-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium/top-hidden-diff.png 34 | await page.reload({ waitUntil: 'networkidle' }); 35 | await page.menu.getMenuItem(showHeaderPath); > 36 | expect(await page.screenshot()).toMatchSnapshot('top-hidden.png', { | ^ 37 | maxDiffPixels: 300, 38 | }); 39 | at /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts:36:37
[chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page: ui-tests/test/settings.spec.ts#L36
1) [chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 311 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts-snapshots/top-hidden-chromium-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium-retry1/top-hidden-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium-retry1/top-hidden-diff.png 34 | await page.reload({ waitUntil: 'networkidle' }); 35 | await page.menu.getMenuItem(showHeaderPath); > 36 | expect(await page.screenshot()).toMatchSnapshot('top-hidden.png', { | ^ 37 | maxDiffPixels: 300, 38 | }); 39 | at /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts:36:37
[chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page: ui-tests/test/mobile.spec.ts#L38
2) [chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page Error: Screenshot comparison failed: 405 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/tree-chromium-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-chromium/tree-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-chromium/tree-diff.png 36 | await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' }); 37 | > 38 | expect(await page.screenshot()).toMatchSnapshot('tree.png', { | ^ 39 | maxDiffPixels: 300, 40 | }); 41 | }); at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:38:37
ui-tests (chromium)
Process completed with exit code 1.
🎭 Playwright Run Summary
2 flaky [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ───────────────────── [firefox] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ─────────────────── 34 passed (2.1m)
🎭 Playwright Run Summary
36 passed (1.7m)
🎭 Playwright Run Summary
1 failed [chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page 1 flaky [chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page 34 passed (1.9m)

Artifacts

Produced during runtime
Name Size
notebook-chromium-test-assets
1.33 MB
notebook-chromium-test-report
1.98 MB
notebook-chromium-updated-snapshots
338 KB
notebook-dist-2152
9.5 MB
notebook-firefox-test-assets
3.15 MB
notebook-firefox-test-report
3.82 MB
notebook-pkgs-2152
57.4 KB