Move handling of the file browser settings to a separate plugin, enable file browser single click navigation #2173
Annotations
3 errors and 1 notice
Test:
ui-tests/test/filebrowser.spec.ts#L41
1) [firefox] › test/filebrowser.spec.ts:32:7 › File Browser › Select one file ────────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Open')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Open')
39 |
40 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
> 41 | expect(toolbar.getByText(text)).toBeVisible();
| ^
42 | });
43 | });
44 |
at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:41:39)
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:40:56
|
Test:
ui-tests/test/filebrowser.spec.ts#L57
2) [firefox] › test/filebrowser.spec.ts:45:7 › File Browser › Select files and folders ───────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
55 | expect(toolbar.getByText('Rename')).toBeHidden();
56 | expect(toolbar.getByText('Open')).toBeHidden();
> 57 | expect(toolbar.getByText('Delete')).toBeVisible();
| ^
58 | });
59 |
60 | test('Select files and open', async ({ page, tmpPath }) => {
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:57:41
|
Test:
ui-tests/test/notebook.spec.ts#L1
3) [firefox] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ──────────────────
Error: "apiRequestContext.fetch: Target page, context or browser has been closed
Call log:
- → POST http://localhost:8888/api/sessions?1729771798027
- user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:131.0) Gecko/20100101 Firefox/131.0
- accept: */*
- accept-encoding: gzip, deflate, br, zstd
- host: localhost:8888
- accept-language: en-US
- content-type: text/plain;charset=UTF-8
- content-length: 172
- referer: http://localhost:8888/notebooks/test-notebook-Notebook-Title-should-be-rendered-firefox/example.ipynb
- x-xsrftoken: 2|c6285fdb|108abb1d65ad5d2d97ff9edfc06cf447|1729771795
- origin: http://localhost:8888
- sec-fetch-dest: empty
- sec-fetch-mode: cors
- sec-fetch-site: same-origin
- connection: keep-alive
- cookie: username-localhost-8888="2|1:0|10:1729771795|23:username-localhost-8888|200:eyJ1c2VybmFtZSI6ICI3MTI1ZmJkOWQwYjk0NmM3YTVkZDViM2Q1NzVjNWM3OCIsICJuYW1lIjogIkFub255bW91cyBMeXNpdGhlYSIsICJkaXNwbGF5X25hbWUiOiAiQW5vbnltb3VzIEx5c2l0aGVhIiwgImluaXRpYWxzIjogIkFMIiwgImNvbG9yIjogbnVsbH0=|494a8999ceb1e98e0706e2513452598f97ff0de4b91264ef904dac5e4c719bc6"; _xsrf=2|c6285fdb|108abb1d65ad5d2d97ff9edfc06cf447|1729771795
" while running route callback.
Consider awaiting `await page.unrouteAll({ behavior: 'ignoreErrors' })`
before the end of the test to ignore remaining routes in flight.
at /home/runner/work/notebook/notebook/ui-tests/node_modules/@jupyterlab/galata/src/galata.ts:961:49
|
Test
3 flaky
[firefox] › test/filebrowser.spec.ts:32:7 › File Browser › Select one file ─────────────────────
[firefox] › test/filebrowser.spec.ts:45:7 › File Browser › Select files and folders ────────────
[firefox] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ───────────────────
33 passed (2.2m)
|
Loading