Add missing "Open..." file menu #2056
Annotations
9 errors and 2 notices
ui-tests/test/filebrowser.spec.ts#L39
1) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Open')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Open')
37 |
38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
> 39 | expect(toolbar.getByText(text)).toBeVisible();
| ^
40 | });
41 | });
42 |
at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39)
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
|
ui-tests/test/filebrowser.spec.ts#L55
2) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ───────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
53 | expect(toolbar.getByText('Rename')).toBeHidden();
54 | expect(toolbar.getByText('Open')).toBeHidden();
> 55 | expect(toolbar.getByText('Delete')).toBeVisible();
| ^
56 | });
57 |
58 | test('Select files and open', async ({ page, tmpPath }) => {
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
|
ui-tests/test/menus.spec.ts#L47
1) [firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File ────────────────────
Error: Screenshot comparison failed:
1 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-file-firefox-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-File-firefox/opened-menu-file-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-File-firefox/opened-menu-file-diff.png
45 | const menu = await page.menu.getOpenMenu();
46 | expect(menu).toBeDefined();
> 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase());
| ^
48 | });
49 | });
50 | });
at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
|
ui-tests/test/menus.spec.ts#L47
1) [firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File ────────────────────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
1 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-file-firefox-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-File-firefox-retry1/opened-menu-file-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-File-firefox-retry1/opened-menu-file-diff.png
45 | const menu = await page.menu.getOpenMenu();
46 | expect(menu).toBeDefined();
> 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase());
| ^
48 | });
49 | });
50 | });
at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
|
ui-tests/test/mobile.spec.ts#L71
2) [firefox] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page
Error: Screenshot comparison failed:
300 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/notebook-firefox-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-firefox/notebook-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-firefox/notebook-diff.png
69 | }
70 |
> 71 | expect(await notebook.screenshot()).toMatchSnapshot('notebook.png');
| ^
72 | await notebook.close();
73 | });
74 | });
at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:71:41
|
ui-tests/test/mobile.spec.ts#L71
2) [firefox] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
300 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/notebook-firefox-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-firefox-retry1/notebook-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-firefox-retry1/notebook-diff.png
69 | }
70 |
> 71 | expect(await notebook.screenshot()).toMatchSnapshot('notebook.png');
| ^
72 | await notebook.close();
73 | });
74 | });
at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:71:41
|
ui-tests/test/filebrowser.spec.ts#L39
3) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Open')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Open')
37 |
38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
> 39 | expect(toolbar.getByText(text)).toBeVisible();
| ^
40 | });
41 | });
42 |
at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39)
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
|
ui-tests/test/filebrowser.spec.ts#L55
4) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ───────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
53 | expect(toolbar.getByText('Rename')).toBeHidden();
54 | expect(toolbar.getByText('Open')).toBeHidden();
> 55 | expect(toolbar.getByText('Delete')).toBeVisible();
| ^
56 | });
57 |
58 | test('Select files and open', async ({ page, tmpPath }) => {
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
|
|
|
2 failed
[firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File ─────────────────────
[firefox] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page
2 flaky
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ─────────────────────
[firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ────────────
31 passed (2.3m)
|
This job failed
Loading