Updated fav-icon Base URL from JupyterLab PageConfig. (#7109)

* Updated fav-icon Base URL from JupyterLab PageConfig. * Reformatted code for reability. * Used for conncatinating fac-icon URL * Lint --------- Co-authored-by: [email protected] <[email protected]> Co-authored-by: Jeremy Tuloup <[email protected]>
jupyter · Oct 17, 2023 · c62caff · c62caff
1 parent 03a27f0
commit c62caff
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/packages/notebook-extension/src/index.ts b/packages/notebook-extension/src/index.ts
@@ -14,7 +14,7 @@ import {
 
 import { Cell, CodeCell } from '@jupyterlab/cells';
 
-import { Text, Time } from '@jupyterlab/coreutils';
+import { PageConfig, Text, Time, URLExt } from '@jupyterlab/coreutils';
 
 import { IDocumentManager } from '@jupyterlab/docmanager';
 
@@ -411,8 +411,12 @@ const tabIcon: JupyterFrontEndPlugin<void> = {
   requires: [INotebookTracker],
   activate: (app: JupyterFrontEnd, tracker: INotebookTracker) => {
     // the favicons are provided by Jupyter Server
-    const notebookIcon = ' /static/favicons/favicon-notebook.ico';
-    const busyIcon = ' /static/favicons/favicon-busy-1.ico';
+    const baseURL = PageConfig.getBaseUrl();
+    const notebookIcon = URLExt.join(
+      baseURL,
+      'static/favicons/favicon-notebook.ico'
+    );
+    const busyIcon = URLExt.join(baseURL, 'static/favicons/favicon-busy-1.ico');
 
     const updateBrowserFavicon = (
       status: ISessionContext.KernelDisplayStatus