Skip to content

Commit

Permalink
ci cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
blink1073 committed Nov 19, 2022
1 parent beba237 commit e1a2ea0
Show file tree
Hide file tree
Showing 8 changed files with 110 additions and 99 deletions.
86 changes: 61 additions & 25 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,46 +40,63 @@ jobs:
- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
with:
python_version: "3.11"
python_version: "3.12"

- name: Install the package
- name: Test the package
run: |
python -m pip install ".[dev,test]"
jlpm run build:test
hatch run cov:test
- name: Unit tests
- name: JavaScript tests
run: |
pip install jupyterlab
jlpm run build:test
jlpm run test
pytest -vv || pytest -vv --lf
- name: Integration Tests
run: |
pip install .
cd
jupyter labextension list 2>&1 | grep -ie "@jupyter-notebook/lab-extension.*enabled.*ok" -
jupyter server extension list 2>&1 | grep -ie "notebook.*enabled" -
python -m jupyterlab.browser_check
test_prerelease:
test_docs:
name: Test Docs
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- name: Checkout
uses: actions/checkout@v3

- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
with:
python_version: "3.10"
- uses: actions/checkout@v3
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
- run: hatch run docs:build

- name: Install the Python dependencies
run: |
pip install --no-deps .
pip install --pre --upgrade ".[dev,test]"
python -m pip install ".[dev,test]"
jlpm run build:test
test_minimum_versions:
name: Test Minimum Versions
timeout-minutes: 20
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
with:
python_version: "3.8"
- uses: jupyterlab/maintainer-tools/.github/actions/install-minimums@v1
with:
only_create_file: 1
- name: Run the unit tests
run: |
export PIP_CONSTRAINT="./contraints_file.txt"
hatch run test:nowarn || hatch run test:nowarn --lf
- name: Python Unit tests
run: |
pytest -vv || pytest -vv --lf
test_prereleases:
name: Test Prereleases
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- uses: actions/checkout@v3
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
with:
python_version: "3.11"
- name: Run the tests
run: |
PIP_PRE=1 hatch run test:nowarn || hatch run test:nowarn --lf
install:
needs: [build]
Expand Down Expand Up @@ -131,7 +148,7 @@ jobs:
jupyter notebook --version
jupyter notebook --help
link_check:
check_linkts:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
Expand All @@ -149,3 +166,22 @@ jobs:
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
- run: pip install -e .
- uses: jupyterlab/maintainer-tools/.github/actions/pre-commit@v1


python_tests_check: # This job does nothing and is only used for the branch protection
if: always()
needs:
- test
- install
- pre_commit
- test_docs
- test_minimum_versions
- test_prereleases
- check_links
- test_sdist
runs-on: ubuntu-latest
steps:
- name: Decide whether the needed jobs succeeded or failed
uses: re-actors/alls-green@release/v1
with:
jobs: ${{ toJSON(needs) }}
38 changes: 0 additions & 38 deletions .github/workflows/docs.yml

This file was deleted.

9 changes: 2 additions & 7 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,10 @@ repos:
["flake8-bugbear==22.6.22", "flake8-implicit-str-concat==0.2.0"]
stages: [manual]

- repo: https://github.com/sirosen/check-jsonschema
- repo: https://github.com/python-jsonschema/check-jsonschema
rev: 0.19.1
hooks:
- id: check-jsonschema
name: 'Check GitHub Workflows'
files: ^\.github/workflows/
types: [yaml]
args: ['--schemafile', 'https://json.schemastore.org/github-workflow']
stages: [manual]
- id: check-github-workflows

- repo: local
hooks:
Expand Down
11 changes: 8 additions & 3 deletions .readthedocs.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
conda:
file: docs/environment.yml
version: 2
sphinx:
configuration: docs/source/conf.py
python:
version: 3
version: 3.8
install:
# install notebook itself
- method: pip
path: ".[docs]"
2 changes: 1 addition & 1 deletion codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ coverage:
project:
default:
target: auto
threshold: 10
threshold: 1
patch:
default:
target: 0%
5 changes: 0 additions & 5 deletions docs/doc-requirements.txt

This file was deleted.

20 changes: 0 additions & 20 deletions docs/environment.yml

This file was deleted.

38 changes: 38 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,13 @@ test = [
"ipykernel",
"jupyterlab_server[test]>=2.13,<3",
]
docs = [
"myst_parser",
"nbsphinx",
"pydata-sphinx-theme",
"sphinx>=1.3.6",
"sphinxcontrib_github_alt",
]
dev = [
"pre-commit",
"hatch"
Expand Down Expand Up @@ -98,6 +105,23 @@ artifacts = [
]
include = ["/notebook"]

[tool.hatch.envs.docs]
features = ["docs"]
[tool.hatch.envs.docs.scripts]
build = "make -C docs html SPHINXOPTS='-W'"

[tool.hatch.envs.test]
features = ["test"]
[tool.hatch.envs.test.scripts]
test = "python -m pytest -vv {args}"
nowarn = "test -W default {args}"

[tool.hatch.envs.cov]
features = ["test"]
dependencies = ["coverage", "pytest-cov"]
[tool.hatch.envs.cov.scripts]
test = "python -m pytest -vv --cov notebook --cov-branch --cov-report term-missing:skip-covered {args}"
nowarn = "test -W default {args}"

[tool.hatch.build.hooks.jupyter-builder]
dependencies = ["hatch-jupyter-builder>=0.2"]
Expand Down Expand Up @@ -128,6 +152,20 @@ filterwarnings = [
"ignore:clear_current is deprecated"
]

[tool.coverage.report]
exclude_lines = [
"pragma: no cover",
"def __repr__",
"if self.debug:",
"if settings.DEBUG",
"raise AssertionError",
"raise NotImplementedError",
"if 0:",
"if __name__ == .__main__.:",
"class .*\bProtocol\\):",
"@(abc\\.)?abstractmethod",
]

[tool.flake8]
ignore = "E501, W503, E402"
builtins = "c, get_config"
Expand Down

0 comments on commit e1a2ea0

Please sign in to comment.