Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.4 Release Schedule #2161

Closed
6 tasks done
ellisonbg opened this issue Feb 8, 2017 · 10 comments
Closed
6 tasks done

4.4 Release Schedule #2161

ellisonbg opened this issue Feb 8, 2017 · 10 comments

Comments

@ellisonbg
Copy link
Contributor

ellisonbg commented Feb 8, 2017

See discussion here: #2022

I think we should make a 4.4 release to enable ipywidgets 6.0 to move forward.

Github Project: https://github.com/jupyter/notebook/projects/3

@jasongrout
Copy link
Member

@SylvainCorlay - did you want to look into that queued execution thing that you say is causing problems with nbextensions? I'm happy to sit down with you and try to think it through - I'm still don't quite understand how those are conflicting.

@SylvainCorlay
Copy link
Member

@SylvainCorlay - did you want to look into that queued execution thing that you say is causing problems with nbextensions? I'm happy to sit down with you and try to think it through - I'm still don't quite understand how those are conflicting.

I have been trying to reproduce it with notebook 5 and could not trigger the faulty behavior. I would be happy to discuss this tomorrow.

@SylvainCorlay
Copy link
Member

Thanks @ellisonbg for opening this. This would be super helpful to go ahead with the ipywidgets release.

@gnestor
Copy link
Contributor

gnestor commented Feb 8, 2017

Ok, does everyone agree that we should push 4.4 out today with just #2022?

@ellisonbg
Copy link
Contributor Author

We should confirm with @minrk @takluyver first as they have been doing lots of the work for 5.0. But I am +1

@minrk
Copy link
Member

minrk commented Feb 8, 2017

I'm fine with 4.4 with just this. Since 4.3 introduced the token stuff, it could be logical to include jupyter notebook password in the backport, since it is related to making notebook auth easier. But since 5.0 is quite soon as well, I don't think it needs a backport.

@ellisonbg
Copy link
Contributor Author

I am fine either way with the jupyter notebook password. If it is easy and quick to backport sounds good, otherwise, no worry.

@gnestor
Copy link
Contributor

gnestor commented Feb 8, 2017

I just UX tested Widget List.ipynb and everything appears to be working properly

@gnestor
Copy link
Contributor

gnestor commented Feb 8, 2017

JS test results:

In /Users/grant/Sites/jupyter/notebook/notebook/tests/base/highlight.js
  Untitled suite in /Users/grant/Sites/jupyter/notebook/notebook/tests/base/highlight.js
    uncaughtError: Wait timeout occured (10000ms)
In /Users/grant/Sites/jupyter/notebook/notebook/tests/base/keyboard.js
  Untitled suite in /Users/grant/Sites/jupyter/notebook/notebook/tests/base/keyboard.js
    uncaughtError: Wait timeout occured (10000ms)
In /Users/grant/Sites/jupyter/notebook/notebook/tests/base/keyboard.js:137
  Untitled suite in /Users/grant/Sites/jupyter/notebook/notebook/tests/base/keyboard.js
    uncaughtError: Couldn't find popup with url containing ''
In /Users/grant/Sites/jupyter/notebook/notebook/tests/base/misc.js
  Untitled suite in /Users/grant/Sites/jupyter/notebook/notebook/tests/base/keyboard.js
    uncaughtError: Wait timeout occured (10000ms)
In /Users/grant/Sites/jupyter/notebook/notebook/tests/base/misc.js:137
  Untitled suite in /Users/grant/Sites/jupyter/notebook/notebook/tests/base/misc.js
    uncaughtError: Couldn't find popup with url containing ''
In /Users/grant/Sites/jupyter/notebook/notebook/tests/base/security.js
  Untitled suite in /Users/grant/Sites/jupyter/notebook/notebook/tests/base/misc.js
    uncaughtError: Wait timeout occured (10000ms)
In /Users/grant/Sites/jupyter/notebook/notebook/tests/base/security.js:137
  Untitled suite in /Users/grant/Sites/jupyter/notebook/notebook/tests/base/security.js
    uncaughtError: Couldn't find popup with url containing ''
In /Users/grant/Sites/jupyter/notebook/notebook/tests/base/utils.js
  Untitled suite in /Users/grant/Sites/jupyter/notebook/notebook/tests/base/security.js
    uncaughtError: ".CodeMirror-code" still did not exist in 10000ms

Python test results:

............................................../Users/grant/Sites/jupyter/nbformat/nbformat/validator.py:233: UserWarning: No schema for validating v2 notebooks
  warnings.warn("No schema for validating v%s notebooks" % version, UserWarning)
..........................................................................Failed to import the site module
Traceback (most recent call last):
  File "/Users/grant/anaconda/lib/python3.5/site.py", line 554, in <module>
    main()
  File "/Users/grant/anaconda/lib/python3.5/site.py", line 540, in main
    known_paths = addusersitepackages(known_paths)
  File "/Users/grant/anaconda/lib/python3.5/site.py", line 281, in addusersitepackages
    user_site = getusersitepackages()
  File "/Users/grant/anaconda/lib/python3.5/site.py", line 257, in getusersitepackages
    user_base = getuserbase() # this will also set USER_BASE
  File "/Users/grant/anaconda/lib/python3.5/site.py", line 246, in getuserbase
    from sysconfig import get_config_var
  File "<frozen importlib._bootstrap>", line 969, in _find_and_load
  File "<frozen importlib._bootstrap>", line 958, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 661, in exec_module
  File "<frozen importlib._bootstrap_external>", line 765, in get_code
  File "<frozen importlib._bootstrap_external>", line 476, in _compile_bytecode
KeyboardInterrupt
..................................................................................................S
----------------------------------------------------------------------
Ran 219 tests in 32.325s

OK (SKIP=1)

None of these seem related to #2022, but please chime in if anything looks suspicious. I will run Travis against 4.x branch before releasing.

@minrk
Copy link
Member

minrk commented Feb 8, 2017

It's a relatively easy backport. There are docs that specifically reference 'new in 5.0' that would need to be updated, though, so it might not be worth the bother.

@minrk minrk closed this as completed Feb 9, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants