Backport #1958 to 4.x: Add an output callback override stack #2022
Conversation
Fix a subtle async bug in processing comm messages. Basically, message processing did not wait for any promises a comm message handler may return to resolve, because comms were not set up to resolve return values of message handlers. This allows us to override output callbacks to redirect output messages, and is used to implement the Output widget, for example. It does not redirect status messages or messages on other channels. Write the get_output_callback_id function that we use. Return after error condition. Some tests for output callback overrides.
jasongrout
changed the title
|
My hope was to not have any more new feature releases on 4.x, so we can push toward getting 5.0 out. But if there's a strong reason that this needs to be in 4.x rather than 5.0, that's okay, too. |
I think it depends on the timing of ipywidgets 6 vs notebook 5 - if notebook 5 is delayed for a long time after ipywidgets 6, I'd like to go ahead and get this in notebook 4.x. For now, we can leave the PR open for anyone that wants to run the ipywidgets beta on notebook 4.x. |
Make the output widget work in notebook 4.3.1 + jupyter/notebook#2022
|
@takluyver - can we still have a 4.4 milestone? Even if we release 5.0, a lot of people won't be able to update to it soon, and this makes it possible for ipywidgets 6.x to work in 4.x. |
|
I'm hoping that the 5.0 release won't particularly be a more problematic upgrade than a new 4.x release. We're short enough on developer time here that I don't feel like we've got effort to spare for more 4.x releases. |
I'm happy to take a crack at doing a very simple 4.4 that just has this backport in it. |
jasongrout
changed the title
But I'll wait until we are closer to a widgets 6.x release - if it ends up taking a lot longer than 5.0, then it's probably a moot point. For now, I'll make a 4.4 milestone again and put this PR in it just to keep track of it. We may decide to forgo the 4.4 after releasing 5.0. |
|
@gnestor I have tested this locally and it works well. We are nearing the ipywidgets 6.0 release and this is a real blocker for us. Would you guys be OK with pushing a notebook 4.4 out so that we can iterate on widgets? |
|
@SylvainCorlay That's ok by me. @takluyver What say you? It seems like we are still at least a week out from a 5.0 release... |
|
OK, if we must, but let's try not to get drawn into any more releases - it pulls away developer time, and we don't have very much of that for notebook now. |
|
@jasongrout @SylvainCorlay @gnestor have all been working really hard getting ready for for the 6.0 release of ipywidgets. Some aspects of this release as it relates to notebook releases:
@gnestor can you take the lead on a 4.4 release? I opened an issue to discuss the 4.4 release #2161 |
|
@ellisonbg Yes, cutting a new release shouldn't take me more than an hour, so not a big deal. |
|
That would be great. Does anyone know of anything else that should be
backported to 4.4?
…On Wed, Feb 8, 2017 at 11:32 AM, Grant Nestor ***@***.***> wrote:
@ellisonbg <https://github.com/ellisonbg> Yes, cutting a new release
shouldn't take me more than an hour, so not a big deal.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2022 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABr0LshqWPQwhdNzeRhlLsWM4pgvM93ks5rahhigaJpZM4LbR80>
.
--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
[email protected] and [email protected]
|
|
Let's ping the mailing list on that too. I don't know of anything else. |
|
I'll write up a short paragraph for release notes for this pr |
|
@jasongrout If you put the release notes here, I will add them to the changelog for you 👌 |
|
@ellisonbg @gnestor thanks a lot for this. |
|
@jasongrout Better yet, comment on this PR regarding releast notes: #2163 |
Backport #1958 to 4.x: Add an output callback override stack
@minrk - what do you think about merging this in 4.x so that ipywidgets 6.x will work with notebook 4.x?
backport of #1958