ci: set minimal permissions to workflows #7070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
|
|
krassowski
reviewed
Sep 22, 2023
There was a problem hiding this comment.
Thank you! jlpm is just a version-pinned alias for yarn. Underneath a lot is delegated to https://github.com/jupyterlab/maintainer-tools so we probably shall review it at some point too.
Co-authored-by: Michał Krassowski <[email protected]>
jtpio
reviewed
Oct 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7069
Mind that I'm not really familiar with the
jlpmcommands and with some of the jupyter workflows called on some actions, so I recommend that you double-check if I haven't removed any write permission that is actually needed =)