Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typings check on CI #7104

Merged
merged 1 commit into from
Oct 12, 2023
+3 −3
Merged

Fix typings check on CI #7104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions notebook/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from jupyter_server.serverapp import flags
from jupyter_server.utils import url_escape, url_is_absolute
from jupyter_server.utils import url_path_join as ujoin
from jupyterlab.commands import ( # type:ignore[import]
from jupyterlab.commands import ( # type:ignore[import-untyped]
get_app_dir,
get_user_settings_dir,
get_workspaces_dir,
Expand All @@ -29,7 +29,7 @@
recursive_update,
)
from jupyterlab_server.handlers import _camelCase, is_url
from notebook_shim.shim import NotebookConfigShimMixin # type:ignore[import]
from notebook_shim.shim import NotebookConfigShimMixin # type:ignore[import-untyped]
from tornado import web
from traitlets import Bool, Unicode, default
from traitlets.config.loader import Config
Expand All @@ -50,7 +50,7 @@ class NotebookBaseHandler(ExtensionHandlerJinjaMixin, ExtensionHandlerMixin, Jup
"""The base notebook API handler."""

@property
def custom_css(self) -> bool:
def custom_css(self) -> t.Any:
return self.settings.get("custom_css", True)

def get_page_config(self) -> dict[str, t.Any]:
Expand Down
Loading