Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ui-tests Configuration in Contributing.md #7124

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

jayeshsingh9767
Copy link
Contributor

While setting up UI tests on my Local System, I have faced issue while using jlpm, Got to know from @krassowski that we need to install Packages of jlpm inside folder ui-tests.

So, This PR will update the CONTRIBUTING.md so that future contributors doesn't face the same.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jayeshsingh9767/notebook/update_contributing_doc

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

CONTRIBUTING.md Outdated
jlpm

#install playwright
npx playwright install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can stick to jlpm for consistency here?

Suggested change
npx playwright install
jlpm playwright install

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio for pointing out.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit e73d410 into jupyter:main Oct 27, 2023
29 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants