Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Lumino Plugin Description (#7008) #7127

Merged
merged 17 commits into from
Oct 27, 2023

Conversation

Dilip-Jain
Copy link
Contributor

Issue No. #7008

Problem

Post Lumino v2 (jupyterlab/lumino#572), plugins support adding a description to it.
@jtpio mentions -

Lumino 2 now supports adding a description to plugins: jupyterlab/lumino#572
Currently most plugins in this repo don't make use of it.
We should add them to the notebook code base, so it's useful for contributors but also for users at some point: jupyterlab/jupyterlab#14536

Solution

Added a description to every plugin.
Fixes #7008

Thank you for considering this pull request, and I welcome any feedback or suggestions for further improvements.
ps: thanks @aditya9110

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch Dilip-Jain/notebook/lumino-plugin-description

@jtpio jtpio added this to the 7.0.x milestone Oct 27, 2023
@jtpio
Copy link
Member

jtpio commented Oct 27, 2023

Nice thanks @Dilip-Jain and @aditya9110 for tackling this!

@jtpio jtpio modified the milestones: 7.0.x, 7.1 Oct 27, 2023
@jtpio
Copy link
Member

jtpio commented Oct 27, 2023

CI failure is unrelated and should be fixed by #7129.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 1ff6293 into jupyter:main Oct 27, 2023
29 checks passed
@Dilip-Jain Dilip-Jain deleted the lumino-plugin-description branch October 27, 2023 12:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a description to plugins
3 participants