-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JupyterLab 4.1.5 packages #7291
Conversation
Seeing the following behavior with the notebook toolbar items, which might be new: notebook-7-toolbar-items.webmWhile on the previous version this seems to be fine: notebook-7-toolbar-items-711.webm |
cc @brichet could this be related to jupyterlab/jupyterlab#15843? |
@jtpio It is probably related to the PR you mentioned, but I don't know why yet. |
The error seems to come from https://github.com/jupyterlab/jupyterlab/blob/864754e0b4274df82ca93296fb9bf7f80ff9f710/packages/ui-components/src/components/toolbar.tsx#L640. |
Maybe it's related to the interface switcher extension from https://github.com/jupyter/notebook/blob/main/packages/lab-extension/src/index.ts (I think that would be the main difference between lab and notebook for the notebook toolbar). Although this one should go through the regular toolbar system via the settings normally. |
I tried to disabled it but have the same issue. But I agree it seems to be the only widget added AFAIK. |
Also this does not seem to be an issue with JupyterLab when testing from this PR (JupyterLab also shows the interface switcher widget in the notebook toolbar). |
I think I found the culprit on Jupyterlab, probably this call If we replace My understanding is that the toolbar is rendered more quickly in Notebook than in Jupyterlab (probably because there is less to render). This does not occur with the fix above. I'll open a PR on Jupyterlab. |
Cool, thanks for investigating this! |
CI now passing with the fix shipped in JupyterLab 4.1.5. Thanks @brichet! |
No description provided.