Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Google] Handle pagination in group API calls #768

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

jrdnbradford
Copy link
Contributor

Closes #767.

The http param was leftover from #764 and has been removed.

The main change is checking for a paging token and continuing to retrieve groups as long as it exists.

@jrdnbradford jrdnbradford changed the title [Google] Handle pagination in API calls [Google] Handle pagination in group API calls Oct 8, 2024
@minrk
Copy link
Member

minrk commented Oct 9, 2024

Great, thank you!

@minrk minrk merged commit 1dfc156 into jupyterhub:main Oct 9, 2024
11 checks passed
@jrdnbradford jrdnbradford deleted the googlegroups-handle-pagination branch October 9, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lookup of Google Groups needs to account for pagination
3 participants