Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update /generate to not split classes & functions across cells #1158

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Update /generate to not split classes & functions across cells #1158

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9a48bd9
Update to ensure no hanging code cells in generated notebooks
srdas Dec 18, 2024
4feb4d1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 18, 2024
1b05277
Update generate.py
srdas Dec 18, 2024
bf63ab9
Merge branch 'main' into fix_generate_hanging_code_cells
srdas Dec 18, 2024
debb571
Merge branch 'main' into fix_generate_hanging_code_cells
srdas Dec 18, 2024
2083eda
Update generate.py
srdas Dec 19, 2024
3dbc1dc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 19, 2024
7d909bb
Update generate.py
srdas Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/jupyter-ai/jupyter_ai/chat_handlers/generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,15 @@ def create_notebook(outline):
nb["cells"].append(nbf.new_markdown_cell("## " + section["title"]))
for code_block in section["code"].split("\n\n"):
nb["cells"].append(nbf.new_code_cell(code_block))

# Post process notebook for hanging cells: merge hanging cell with the previous cell
nb_cells = []
dlqqq marked this conversation as resolved.
Show resolved Hide resolved
for cell in nb["cells"]:
if (cell["cell_type"] == "code") and (cell["source"][0] == " "):
dlqqq marked this conversation as resolved.
Show resolved Hide resolved
nb_cells[-1]["source"] = nb_cells[-1]["source"] + "\n\n" + cell["source"]
else:
nb_cells.append(cell)
nb["cells"] = nb_cells
return nb


Expand Down
Loading