Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded LangChain, fixed prompts for Bedrock #401

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Upgraded LangChain, fixed prompts for Bedrock #401

merged 5 commits into from
Oct 5, 2023

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Oct 3, 2023

Fixes #399.

@3coins 3coins force-pushed the fix-bedrock-support branch from b02e1d2 to 4e3bcec Compare October 3, 2023 02:32
@3coins 3coins added bug Something isn't working maintenance Change related to maintenance of the repository labels Oct 3, 2023
@3coins 3coins force-pushed the fix-bedrock-support branch from 943c843 to 7ab465b Compare October 3, 2023 02:40
@3coins 3coins marked this pull request as ready for review October 3, 2023 02:54
@3coins
Copy link
Collaborator Author

3coins commented Oct 3, 2023

Moving this to draft, will wait for this PR from LangChain to be merged.
langchain-ai/langchain#11301

@3coins 3coins self-assigned this Oct 3, 2023
@3coins 3coins marked this pull request as draft October 3, 2023 18:48
@3coins 3coins force-pushed the fix-bedrock-support branch from 6186ecd to f8a0ab2 Compare October 5, 2023 05:53
@3coins 3coins marked this pull request as ready for review October 5, 2023 13:40
@3coins 3coins requested a review from dlqqq October 5, 2023 13:40
dlqqq
dlqqq approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for working on Bedrock support so promptly. In the future, I think we definitely need to revisit DefaultChatHandler.create_llm_chain() and see if we can simplify the way we are building the complete prompt template.

@3coins 3coins merged commit 7f85400 into jupyterlab:main Oct 5, 2023
4 checks passed
@3coins 3coins mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlqqq dlqqq dlqqq approved these changes

Assignees

@3coins 3coins

Labels
bug Something isn't working maintenance Change related to maintenance of the repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bedrock access is broken
2 participants
@3coins @dlqqq