-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure initials appear in collaborative mode #443
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Bug label and review is appreciated. Would love to use the official extension instead of my forked repo after the next release |
BTW, to keep your branch's commit history clean while staying based on the latest
Here are the commands to emulate my setup. # rename the official remote to `origin`, if necessary
# git remote rename <old-remote> origin
# add fork remote
git remote add self [email protected]:americandatascience/jupyter-ai.git
# set your dev branch to fix-initials
git checkout main
git checkout -b fix-initials
# reset main to track origin
git checkout main
git reset --hard origin/master
git branch -u origin
# push your dev branch to your fork
git checkout fix-initials
git push -u self You should be able to change the branch of this PR to Then, to sync with # get latest main
git checkout main
git pull
# rebase branch onto main
git checkout fix-initials
git rebase main
git push to sync your PR's branch with |
@meeseeksdev please backport to 1.x |
@aychang95 Awesome work! 🎉 |
Co-authored-by: Andrew Chang <[email protected]>
* Ensure initials appear in collaborative mode * Set default initials and use instead of null current_user attr * Black format to avoid pre-commit failure * Getattr does not return default because initials attr still exists even though it's None * optimize and set to one initial var
* Ensure initials appear in collaborative mode * Set default initials and use instead of null current_user attr * Black format to avoid pre-commit failure * Getattr does not return default because initials attr still exists even though it's None * optimize and set to one initial var
Relevant issues and PRs:
#302
#316
This tiny PR addresses the issue where
self.current_user
still provides aNone
var forinitials
in collaborative mode.If initials are already generated from the names, then we shouldn't overwrite them with
None
.