Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adding introductory documentation to the launch buttons #432

Merged
merged 6 commits into from
Jan 14, 2022

Conversation

choldgraf
Copy link
Contributor

References

In preparation for adding a retrolab tutorial to the top row of try.jupyter.org, I thought it'd be helpful to add two quick introductory notebooks for the Lab / Retrolab buttons on the JupyterLite docs. This way, users see some content when they click the button, and can have a few pointers in the right direction. This may be a short-term solution until we can flesh out some more introductory content that is fitting for try.jupyter.org, but what do people think about this as a first step?

Documentation changes

  • There are now two lightweight "introductory" notebooks that are meant to guide people on their first steps with the interfaces.
  • The buttons in the top left of the docs now open an intro notebook when JupyterLite is loaded.

@github-actions
Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

@bollwyvl
Copy link
Collaborator

This is good content.

Given the size breakdown on that other issue, I don't think we'd necessarily want to always point directly at a particular python notebook with its 30mb load as the very first introduction. If it was a notebook, a JS kernel notebook would be far lighter weight, and is more likely to stay in this repo, and could still make some pretties with e.g. vega. However, more likely, we'd want to rework the prose into steps of a tour, and start that off.

Over on https://ipydrawio.readthedocs.io and https://pidgy.readthedocs.io i've played around with some other approaches to flexibly launching the demo with some URL-based configuring... perhaps we consider some alternate forms, including offering all of the examples as potential starting points.

More broadly: even if we did bring the capability into try.jupyter.org, this project's main is not ready to be the destination, even if the released package could build a site, deployed on try.jupyter.org/lite/, for example, that was. We do what we can to keep it working here, but you know...

@choldgraf
Copy link
Contributor Author

choldgraf commented Dec 22, 2021

Gotcha - makes sense to me. Do you think we should close this PR? Or rework the content somehow? I suspect that many people will land on the jupyterlite docs and just click one of the try buttons in the top left, since that's a high eyeballs spot, and might be confused at the lack of context since they haven't read anything else.

I didn't realize size was a concern (WASM and jupyterlite continues to work in mysterious ways to me haha). Maybe it should just be a markdown file?

@jtpio
Copy link
Member

jtpio commented Dec 23, 2021

Thanks @choldgraf!

Do you think we should close this PR? Or rework the content somehow?

Probably we can still keep the intro.ipynb and intro-retro.ipynb as they would show up in the file browser at the top-level.

Another idea would be to open examples/README.md by default with links to these notebooks. And iterate a bit on the README.md to make it more like a proper gallery of examples (could be done at a later stage).

examples/README.md Outdated Show resolved Hide resolved
@jtpio jtpio added this to the 0.1.0 milestone Dec 23, 2021
@choldgraf
Copy link
Contributor Author

choldgraf commented Dec 23, 2021

Another idea would be to open examples/README.md by default with links to these notebooks. And iterate a bit on the README.md to make it more like a proper gallery of examples (could be done at a later stage).

This sounds like a nice idea - let me know if you'd like this in the current PR or not. Basically just having any kind of landing page would I think be a benefit to the user, even if it just a sentence or two with pointers

@jtpio
Copy link
Member

jtpio commented Dec 23, 2021

@choldgraf if you would like to do it in this PR that would be great, thanks!

@choldgraf
Copy link
Contributor Author

ok - can you give me an idea of what kind of content you think is best there? Something like a few paragraphs about JupyterLite in general with pointers to the intro notebooks? Anything else?

@jtpio
Copy link
Member

jtpio commented Dec 23, 2021

That would already be a good introduction yes.

There was also some previous discussions about this in #168 and related issues.

@jtpio
Copy link
Member

jtpio commented Jan 13, 2022

Just rebased onto main to grab the latest updates.

Testing on RTD, opening a notebook by default doesn't feel too heavy at first. Although it's true some dependencies are pulled, and the first cell run still takes some time but it's a bit faster now thanks to #433.

@jtpio
Copy link
Member

jtpio commented Jan 13, 2022

However there seems to be a micropip related issue when opening the notebook with the new Pyodide 0.19 and lite 0.1.0a19:

image

But this does not seem to be a problem when testing on https://jupyterlite.github.io/demo/, which doesn't pre-cache the wheels:

image

@jtpio
Copy link
Member

jtpio commented Jan 13, 2022

However there seems to be a micropip related issue when opening the notebook with the new Pyodide 0.19 and lite 0.1.0a19:

Ah nevermind that, this was most likely a caching issue. Trying again in a private window seems to work fine:

startup-open-notebook.mp4

docs/_templates/launch.html Outdated Show resolved Hide resolved
@bollwyvl
Copy link
Collaborator

Format intro notebooks

I've been wondering: we should probably add a no-op nbconvert --to notebook to our linter, as the "one line of JSON" is even less ergonomic than a regular ipynb 🤣

docs/_templates/launch.html Outdated Show resolved Hide resolved
@jtpio
Copy link
Member

jtpio commented Jan 13, 2022

Since this is good content, I would be in favor of getting this in.

We can keep the demo link in the project description of the repo (and similar links) as it is now without the ?path=:

image

cc @bollwyvl since you had a comment about loading times above

@choldgraf
Copy link
Contributor Author

@jtpio I can probably put a quick cycle into this (say, 30 minutes) if I have a really clear idea of what new content needs to be in here, but probably don't have time to do more complex iterations. Let me know if you'd prefer to just merge it in, or if I should make some changes first

@jtpio
Copy link
Member

jtpio commented Jan 13, 2022

Thanks @choldgraf.

Another idea would be to open examples/README.md by default with links to these notebooks. And iterate a bit on the README.md to make it more like a proper gallery of examples (could be done at a later stage).

Actually the README opens with the text editor by default for now and not the markdown preview, which makes opening that file with ?path= less interesting I believe. Although we could override the preferred factory for markdown files to open with the markdown preview on the demo ReadTheDocs deployment.

Which is why we could just keep the current content as it is with this PR, and iterate later if needed.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 25857b9 into jupyterlite:main Jan 14, 2022
@choldgraf
Copy link
Contributor Author

thanks for the iteration and suggestions all :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants