Improve error message when file path cannot be resolved

jvalue · May 21, 2024 · 63c607b · 63c607b
1 parent ad744b7
commit 63c607b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/libs/language-server/src/lib/validation/checks/import-definition.spec.ts b/libs/language-server/src/lib/validation/checks/import-definition.spec.ts
@@ -100,13 +100,13 @@ describe('Validation of ImportDefinition', () => {
       expect(validationAcceptorMock).toHaveBeenNthCalledWith(
         1,
         'error',
-        'Import cannot be resolved.',
+        'Import from "not-existing-imported-file-deeper.jv" could be resolved. Check if the file exists in the given location.',
         expect.any(Object),
       );
       expect(validationAcceptorMock).toHaveBeenNthCalledWith(
         2,
         'error',
-        'Import cannot be resolved.',
+        'Import from "./not-existing-imported-file-deeper.jv" could be resolved. Check if the file exists in the given location.',
         expect.any(Object),
       );
     });
@@ -121,13 +121,13 @@ describe('Validation of ImportDefinition', () => {
       expect(validationAcceptorMock).toHaveBeenNthCalledWith(
         1,
         'error',
-        'Import cannot be resolved.',
+        'Import from "existing-imported-file.njv" could be resolved. Check if the file exists in the given location.',
         expect.any(Object),
       );
       expect(validationAcceptorMock).toHaveBeenNthCalledWith(
         2,
         'error',
-        'Import cannot be resolved.',
+        'Import from "./existing-imported-file.njv" could be resolved. Check if the file exists in the given location.',
         expect.any(Object),
       );
     });

diff --git a/libs/language-server/src/lib/validation/checks/import-definition.ts b/libs/language-server/src/lib/validation/checks/import-definition.ts
@@ -18,9 +18,13 @@ function checkPathExists(
 ): void {
   const resolvedImport = props.importResolver.resolveImport(importDefinition);
   if (resolvedImport === undefined) {
-    props.validationContext.accept('error', 'Import cannot be resolved.', {
-      node: importDefinition,
-      property: 'path',
-    });
+    props.validationContext.accept(
+      'error',
+      `Import from "${importDefinition.path}" could be resolved. Check if the file exists in the given location.`,
+      {
+        node: importDefinition,
+        property: 'path',
+      },
+    );
   }
 }