-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composite blocktypes: Basic functionality #411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhazn
force-pushed
the
composite-blocktypes
branch
from
August 4, 2023 15:38
4aad709
to
9655288
Compare
rhazn
force-pushed
the
composite-blocktypes
branch
from
August 19, 2023 15:50
9655288
to
77d317e
Compare
9 tasks
rhazn
changed the title
WIP: Composite blocktypes
WIP: Composite blocktypes: Basic functionality
Aug 25, 2023
rhazn
changed the title
WIP: Composite blocktypes: Basic functionality
Composite blocktypes: Basic functionality
Aug 29, 2023
Co-authored-by: Georg Schwarz <[email protected]>
rhazn
force-pushed
the
composite-blocktypes
branch
from
August 29, 2023 15:10
cb90802
to
d766cc2
Compare
libs/language-server/src/lib/meta-information/composite-blocktype-meta-inf.ts
Outdated
Show resolved
Hide resolved
libs/language-server/src/lib/validation/checks/block-definition.ts
Outdated
Show resolved
Hide resolved
georg-schwarz
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Looks quite intuitive after the refactor to me :)
I left a few very nitpicky comments. Feel free to ignore them as most of them are quite opinionated I guess ;-)
georg-schwarz
approved these changes
Aug 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://github.com/jvalue/jayvee/tree/main/rfc/0008-builtin-blocktypes
Reference #217, out of scope for this PR:
File with composite blocks to test
For testing, using e.g., the above source code: