-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabular extension exec tests #458
Conversation
… in tabular extension tests - Extracted splitLines into string-util in @jvalue/jayvee-execution for the same reason
… functions to create BinaryFile and TextFile from local files - Renamed utils.ts into test-infrastructure-util.ts and moved into utils subdirectory
- Added same fix for setImmediate which is used inside 'fast-csv' (used inside csv-interpreter)
I have found two things that need clarification:
This is due to |
Yes, I believe so.
Good catch! I'd expect that only a row is added if there is data in it. |
We decided that this fix is ok, we just have to document this behavior somewhere. |
Closes #417
This PR adds tests to all the block-executors of the tabular extension.
Note: This conflicts with #456 (this is newer -> the other will have to be adjusted)
Important changes
file-util.ts
fromlibs/extensions/std
tolibs/execution
due to required usage in tabular extension tests.libs/extensions/std/exec/src/text-file-interpreter-executor.ts#splitLines
intolib/execution/src/lib/util/string-util.ts
also due to usage in tabular testslibs/execution/test/utils.ts
into folder with multiple utils (oldutils.ts
renamed toutils/test-infrastructure-util.ts
)jsdom
fixes forstructuredClone
andsetImmediate