Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Improve examples section #508

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Docs: Improve examples section #508

merged 4 commits into from
Jan 18, 2024

Conversation

tordans
Copy link
Contributor

@tordans tordans commented Jan 17, 2024

I was mislead by the intro#examples section which links to github which in turn does not have syntax highlighting which makes the examples a lot more unattractive than the docs-examples-page.

The idea of this PR is to change the intro to link to the separate page. And in turn put all details on the separate examples page.

However, the linking is likely not finished, yet and the example category intro might not be able to handle links. Someone with more information on the docs generator will have to finish this PR.

Copy link

github-actions bot commented Jan 17, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@tordans
Copy link
Contributor Author

tordans commented Jan 18, 2024

I have read the CLA Document and I hereby sign the CLA

@georg-schwarz
Copy link
Member

Thanks for your contribution! I extended your PR a little with some docusaurus-specific mechanisms to customize the category page (see the added README.mdx file).

@georg-schwarz georg-schwarz requested a review from joluj January 18, 2024 16:04
@georg-schwarz georg-schwarz merged commit 7aae6d6 into jvalue:main Jan 18, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
@tordans tordans deleted the patch-1 branch January 18, 2024 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants