Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Code Actions #565

Merged
merged 7 commits into from
May 23, 2024
Merged

Import Code Actions #565

merged 7 commits into from
May 23, 2024

Conversation

georg-schwarz
Copy link
Member

@georg-schwarz georg-schwarz commented May 16, 2024 •
edited
Loading

Builds on #564 - so merge that one first and rebase!

  • path completion based on files in fs
  • jump to file when clicking on import path
  • import action if not defined element exists in another file

@georg-schwarz georg-schwarz changed the title File import path completion Import Code Actions May 17, 2024
@georg-schwarz georg-schwarz force-pushed the file-import-path-completion branch from fc68f55 to 5b3c0ca Compare May 21, 2024 13:35
@georg-schwarz georg-schwarz marked this pull request as ready for review May 21, 2024 14:30
@georg-schwarz georg-schwarz requested a review from rhazn May 21, 2024 15:03
rhazn
rhazn approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@rhazn rhazn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 👍

@georg-schwarz georg-schwarz merged commit b20fcd9 into main May 23, 2024
3 checks passed
@georg-schwarz georg-schwarz deleted the file-import-path-completion branch May 23, 2024 17:05
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhazn rhazn rhazn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georg-schwarz @rhazn