Update main to development branch #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from: ad744b78dcef3bb1bf5ac7dd4c8c77a361322343 to: 8bf5053a7081e57fca1a971d46b490851dc03d1f
1. The structuredClone() function from javascript loses type information, so it's not suitable for a typescript project. I solved this by converting the old values into JSON, parsing that into a new object and then manually asserting the types again. 2. The output columns created during a transform exectution had the name of the output variable from the transform block, not the specified `outputColumnName` from the TableTransform block. This was due to a bug in TsTable.addColumn, which did not ensure the supplied name was the same as the actual columnname
TungstnBallon
force-pushed
the
other-type-system
branch
from
db79020
to
ebce21d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updated main to the latest developent version
closes #1