fix(pdm): support lock-spec >=4.5 #122
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvolkman
reviewed
Oct 4, 2024
| @@ -58,6 +58,11 @@ def get_development_dependencies(lock: Dict[str, Any]) -> Dict[str, List[Require | |||
| return {group: [Requirement(EDITABLE_PATTERN.sub("", dep)) for dep in deps] for group, deps in dep_groups.items()} | |||
|
|
|||
|
|
|||
| def get_excluded_packages(lock: Dict[str, Any]) -> List[str]: | |||
| packages = lock.get("tool", {}).get("pdm", {}).get("resolution", {}).get("excludes", []) | |||
There was a problem hiding this comment.
What is this section? Do you have an example lock file?
There was a problem hiding this comment.
we make use of tool.pdm.resolution.excludes.
packages listed there will also not be contained in the lockfile, that's why i explicitly filter them out here.
I'm not completely sure if this is required or not.
There was a problem hiding this comment.
I see. So this seems orthogonal to the multi-platform issue from #115, right? If that's the case, I don't have a problem with this change. It seems like we'll need to handle both cases.
Do you know why the tests are failing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now running into similar issues as #115.
I know this change is most likely insufficient, but unblocks us for now.
let's take this as a starting point for discussion :)