justify etcd sync retry duration in comment

k0sproject · Nov 8, 2024 · 6f772c3 · 6f772c3
1 parent d443902
commit 6f772c3
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/component/controller/etcd.go b/pkg/component/controller/etcd.go
@@ -107,8 +107,11 @@ func (e *Etcd) syncEtcdConfig(ctx context.Context, etcdRequest v1beta1.EtcdReque
 			etcdResponse, err = e.JoinClient.JoinEtcd(ctx, etcdRequest)
 			return err
 		},
+		// When joining multiple nodes in parallel, etcd can lose consensus and will return 500 responses
+		// Allow for more time to recover (~ 15 minutes)
+		retry.Attempts(20),
 		retry.Delay(1*time.Second),
-		retry.MaxJitter(1*time.Second),
+		retry.MaxDelay(60*time.Second),
 		retry.Context(ctx),
 		retry.LastErrorOnly(true),
 		retry.OnRetry(func(attempt uint, err error) {