-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator [N] [CI] nri-plugins-operator (0.3.2) #3685
operator [N] [CI] nri-plugins-operator (0.3.2) #3685
Conversation
Dear @fmuyassarov, Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.
|
Hi @Allda @mporrato We can fix the category in the operator but then we need to cut a release again and then bundle it - just for the category change right? Or is there a way to avoid cutting a new release in our operator to pass this failed check here? |
719465d
to
3798c91
Compare
We did cut a new release v0.3.1 and bundle is now updated accordingly. |
/test all |
@fmuyassarov: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1e27981
to
d3db4dc
Compare
/hold |
d3db4dc
to
1e09a17
Compare
/test kiwi |
@fmuyassarov: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1e09a17
to
43daaa8
Compare
43daaa8
to
5cd7a75
Compare
/hold cancel |
/merge possible |
1 similar comment
/merge possible |
/merge possible |
1 similar comment
/merge possible |
/approve |
@fmuyassarov: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add an initial version of the nri-plugins-operator. Signed-off-by: Feruzjon Muyassarov <[email protected]>
5cd7a75
to
33cc81f
Compare
/merge possible |
/merge possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@kad: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @Allda, |
/merge possible |
@fmuyassarov Hey, yes that's correct. New operator needs to be reviewd by some of us. Followup will be merged automatically based on you ci.yaml config. Thanks for your contribution! |
Submit nri-plugins-operator (0.3.2) initial version.