Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator [N] [CI] nri-plugins-operator (0.3.2) #3685

Conversation

fmuyassarov
Copy link
Contributor

@fmuyassarov fmuyassarov commented Dec 22, 2023

Submit nri-plugins-operator (0.3.2) initial version.

@openshift-ci openshift-ci bot requested review from haripate and tomasbakk December 22, 2023 21:05
@github-actions github-actions bot changed the title operator nri-plugins-operator (0.3.0) operator [N] [CI] nri-plugins-operator (0.3.0) Dec 22, 2023
Copy link
Contributor

Dear @fmuyassarov,
Some errors and/or warnings were found while doing the check of your operator (nri-plugins-operator/0.3.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
🐛 Value : (nri-plugins-operator.v0.3.0) csv.Metadata.Annotations["categories"] value Performance is not in the set of custom categories

@fmuyassarov
Copy link
Contributor Author

Hi @Allda @mporrato
In our operator GitHub repo we are using custom categories.json. But when we bundled the operator for submission PR checks failed because it doesn’t recognize our custom category.

We can fix the category in the operator but then we need to cut a release again and then bundle it - just for the category change right? Or is there a way to avoid cutting a new release in our operator to pass this failed check here?

@fmuyassarov fmuyassarov force-pushed the submit-nri-plugins-operator branch from 719465d to 3798c91 Compare December 28, 2023 11:59
@github-actions github-actions bot changed the title operator [N] [CI] nri-plugins-operator (0.3.0) operator [N] [CI] nri-plugins-operator (0.3.1) Dec 28, 2023
@fmuyassarov
Copy link
Contributor Author

Hi @Allda @mporrato In our operator GitHub repo we are using custom categories.json. But when we bundled the operator for submission PR checks failed because it doesn’t recognize our custom category.

We can fix the category in the operator but then we need to cut a release again and then bundle it - just for the category change right? Or is there a way to avoid cutting a new release in our operator to pass this failed check here?

We did cut a new release v0.3.1 and bundle is now updated accordingly.

@fmuyassarov
Copy link
Contributor Author

/test all

Copy link

openshift-ci bot commented Dec 28, 2023

@fmuyassarov: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fmuyassarov fmuyassarov force-pushed the submit-nri-plugins-operator branch 3 times, most recently from 1e27981 to d3db4dc Compare December 29, 2023 07:57
@fmuyassarov
Copy link
Contributor Author

/hold

@github-actions github-actions bot changed the title operator [N] [CI] nri-plugins-operator (0.3.1) operator [N] [CI] nri-plugins-operator (0.3.1-dirty) Dec 29, 2023
@fmuyassarov fmuyassarov force-pushed the submit-nri-plugins-operator branch from d3db4dc to 1e09a17 Compare December 29, 2023 08:07
@fmuyassarov
Copy link
Contributor Author

/test kiwi

Copy link

openshift-ci bot commented Dec 29, 2023

@fmuyassarov: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test kiwi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fmuyassarov
Copy link
Contributor Author

/hold cancel

@framework-automation
Copy link
Collaborator

/merge possible

1 similar comment
@framework-automation
Copy link
Collaborator

/merge possible

@github-actions github-actions bot changed the title operator [N] [CI] nri-plugins-operator (0.3.1-dirty) operator [N] [CI] nri-plugins-operator (0.3.2) Dec 29, 2023
@framework-automation
Copy link
Collaborator

/merge possible

1 similar comment
@framework-automation
Copy link
Collaborator

/merge possible

@fmuyassarov
Copy link
Contributor Author

/approve
/lgtm

Copy link

openshift-ci bot commented Dec 29, 2023

@fmuyassarov: you cannot LGTM your own PR.

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Add an initial version of the nri-plugins-operator.

Signed-off-by: Feruzjon Muyassarov <[email protected]>
@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation
Copy link
Collaborator

/merge possible

Copy link

@kad kad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@fmuyassarov fmuyassarov requested a review from kad December 29, 2023 12:56
Copy link

openshift-ci bot commented Dec 29, 2023

@kad: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fmuyassarov
Copy link
Contributor Author

Hi @Allda,
Would you mind to give authorized label or approve the PR? I think it is not getting merged since it is a new operator but probably for the following releases we will be able to merge it ourselves.

@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation framework-automation merged commit b95b0af into k8s-operatorhub:main Jan 5, 2024
13 checks passed
@Allda
Copy link
Collaborator

Allda commented Jan 5, 2024

@fmuyassarov Hey, yes that's correct. New operator needs to be reviewd by some of us. Followup will be merged automatically based on you ci.yaml config. Thanks for your contribution!

@fmuyassarov fmuyassarov deleted the submit-nri-plugins-operator branch January 5, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants