Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up go.mod, get rid of client-go v1.5.2 #1353

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Nov 6, 2024

client-go 1.5.2 has been retracted and having it here as a dependency forces not just Multus, but everyone who imports Multus to do the same replace dance with tons of Kube dependencies.

From what I can see, there is simply no need to replace tons of dependencies. So I cleaned it up and go mod tidy and go build are happy.

Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up and contribution on this one!

Copy link
Member

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@coveralls
Copy link

Coverage Status

coverage: 56.454% (-7.4%) from 63.857%
when pulling 808185b on xrstf:master
into e1a0d2a on k8snetworkplumbingwg:master.

@s1061123 s1061123 merged commit 781ecda into k8snetworkplumbingwg:master Nov 7, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants