Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy jvm*-client.options from Cassandra base configs and logback files #44

Merged
merged 5 commits into from
May 29, 2024
Merged

Copy jvm*-client.options from Cassandra base configs and logback files #44

merged 5 commits into from
May 29, 2024

Conversation

burmanm
Copy link
Collaborator

@burmanm burmanm commented May 27, 2024

Fixes #42

rzvoncek
rzvoncek approved these changes May 29, 2024
View reviewed changes
Copy link

@rzvoncek rzvoncek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Changes manually tested and consulted internally.

@burmanm burmanm merged commit 16a31a0 into k8ssandra:main May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzvoncek rzvoncek rzvoncek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config builder needs to copy logback.xml and jvm*-client.options
2 participants
@burmanm @rzvoncek