Add ability to override ports and IPs for source cluster. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miles-Garnsey
force-pushed
the
feature/oride-src-netaddr
branch
from
2e38137 to
9bcd638
Compare
adejanovski
approved these changes
Jun 25, 2024
Co-authored-by: Alexander Dejanovski <[email protected]>
burmanm
reviewed
Jul 15, 2024
| SourceNamespace: cmd.Flag("source-namespace").Value.String(), | ||
| DestNamespace: cmd.Flag("dest-namespace").Value.String(), | ||
| ServiceAccount: cmd.Flag("serviceaccount-name").Value.String(), | ||
| OverrideSourceIP: cmd.Flag("override-src-ip").Value.String(), |
There was a problem hiding this comment.
issue: How is this supposed to work when there's no such flag registered in the RegisterClusterCmd? The register above says:
RegisterClusterCmd.Flags().String("oride-src-ip"
Thus, using the parameter name oride-src-ip and this one uses override-src-portto get the value?
There was a problem hiding this comment.
Oops, looks like you're right indeed. I've pushed a fix here #56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50